Skip to content

serial: Some yak shaving

Uwe Kleine-König (The Capable Hub) linux-doc linux-serial lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest7 patches 2 repliesIn review
  2. v28 patches 8 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7serial: txx9: Drop noop probe function and dangerous remove callbackdrivers/tty/serial/serial_txx9.c+3 -520 replies
2/7serial: txx9: Drop usage of uart_match_port()drivers/tty/serial/serial_txx9.c+6 -12 replies
3/7serial: 8250: Make uart_match_port() a 8250 specific functionDocumentation/driver-api/serial/driver.rst drivers/tty/serial/8250/8250_core.c drivers/tty/serial/serial_core.c +1 more+27 -310 replies
4/7serial: 8250: Simplify serial8250_match_port()drivers/tty/serial/8250/8250_core.c+0 -20 replies
5/7serial: 8250: Fix corner case for port matchingdrivers/tty/serial/8250/8250.h drivers/tty/serial/8250/8250_hub6.c drivers/tty/serial/8250/8250_platform.c +2 more+15 -110 replies
6/7serial: 8250: hub6: Add cleanup codedrivers/tty/serial/8250/8250.h drivers/tty/serial/8250/8250_hub6.c drivers/tty/serial/8250/8250_platform.c+11 -10 replies
7/7serial: 8250: pnp: Annotate init and exit functions for conditional discardingdrivers/tty/serial/8250/8250_pnp.c+2 -20 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchAtsushi NemotoGeert UytterhoevenAndy Shevchenko
1/7R-b T-b A-b
2/7R-b R-b
3/7A-b
4/7A-b
5/7A-b
6/7A-b
7/7A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/7] serial: Some yak shaving

Hello,

v2 of this series can be found at
https://lore.kernel.org/linux-serial/[email protected]
. Changes since then:

- Drop "serial: txx9: Simplify knowing that .iotype is always UPIO_PORT" as the assumption that .iotype is always UPIO_PORT proved to be wrong. Thanks to Atsushi Nemoto and Geert Uytterhoeven for finding and proving that.
- Reworked commit log of "serial: txx9: Drop usage of uart_match_port()" and add a code comment to justify the comparison.
- Fix a build issue in "serial: 8250: hub6: Add cleanup code"
- Added tags received in v2. Andy liked the v2 series in reply to the cover letter. I applied his Ack to all patches but "serial: txx9:
Drop usage of uart_match_port()" as this changed. I would expect he agrees to this patch, too, but I'm conservative here.
- (trivially) rebase to yesterday's next
- Drop Alan Cox from Cc:, fix email address for Russell King

Best regards
Uwe

Uwe Kleine-König (The Capable Hub) (7):
serial: txx9: Drop noop probe function and dangerous remove callback
serial: txx9: Drop usage of uart_match_port()
serial: 8250: Make uart_match_port() a 8250 specific function
serial: 8250: Simplify serial8250_match_port()
serial: 8250: Fix corner case for port matching
serial: 8250: hub6: Add cleanup code
serial: 8250: pnp: Annotate init and exit functions for conditional
discarding

 Documentation/driver-api/serial/driver.rst |  2 +-
 drivers/tty/serial/8250/8250.h             | 10 +++-
 drivers/tty/serial/8250/8250_core.c        | 25 ++++++++-
 drivers/tty/serial/8250/8250_hub6.c        | 11 ++--
 drivers/tty/serial/8250/8250_platform.c    |  9 +++-
 drivers/tty/serial/8250/8250_pnp.c         |  4 +-
 drivers/tty/serial/8250/Kconfig            |  4 +-
 drivers/tty/serial/8250/Makefile           |  2 +-
 drivers/tty/serial/serial_core.c           | 27 ----------
 drivers/tty/serial/serial_txx9.c           | 62 ++++------------------
 include/linux/serial_core.h                |  2 -
 11 files changed, 61 insertions(+), 97 deletions(-)

base-commit: 2697ef8943c9985c14708a6429e21812693857b2

Signature · 1 line
2.55.0.11.g153666a7d9bb