Skip to content

pinctrl: airoha: add EcoNet EN7528 pin controller support

Ahmed Naseef linux-devicetree linux-gpio linux-mediatek lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 9 repliesIn review
  2. v13 patches 9 repliesSuperseded

Changes in v2 from the cover letter

- 2/3: move patternProperties after properties, and allOf to the end before additionalProperties (Krzysztof Kozlowski).
- Rebased on linux-pinctrl/for-next.
- Link to v1:
https://lore.kernel.org/linux-gpio/[email protected]/

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3pinctrl: airoha: limit GPIO interrupts to interrupt-capable pinsdrivers/pinctrl/airoha/airoha-common.h drivers/pinctrl/airoha/pinctrl-airoha.c drivers/pinctrl/airoha/pinctrl-an7563.c +3 more+35 -50 replies
2/3dt-bindings: pinctrl: Add EcoNet EN7528 pin controllerDocumentation/devicetree/bindings/pinctrl/econet,en7528-pinctrl.yaml+190 -08 replies
3/3pinctrl: airoha: add support of en7528 SoCdrivers/pinctrl/airoha/Kconfig drivers/pinctrl/airoha/Makefile drivers/pinctrl/airoha/pinctrl-en7528.c+1218 -20 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchBenjamin LarssonConor Dooley
1/3R-b
2/3R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] pinctrl: airoha: add EcoNet EN7528 pin controller support

The EcoNet EN7528 is a MIPS SoC that uses the same pin controller and GPIO IP as the Airoha SoCs, so it reuses the shared driver code introduced by the split into per-SoC drivers. Its register layout differs from every existing variant though: all IOMUX mode bits live in a single CHIP SCU register plus a few spill-over bits in IOMUX Control 3, EJTAG has its own enable register, and every pin configuration register is at a different offset than on EN7523.

It also differs in a way the shared code did not model: only GPIO0-GPIO15 are wired to the interrupt controller, while the driver assumed all AIROHA_NUM_PINS GPIOs could raise an interrupt. Patch 1 adds a num_irq_pins field to the per-SoC match data to describe that, bounds the interrupt callbacks and handler with it, and feeds it to gpiolib through gpio_irq_chip::init_valid_mask so gpiod_to_irq() fails up front for a pin that can never be an interrupt source. All existing SoCs pass AIROHA_NUM_PINS and are unaffected.

Patch 2 documents the binding, patch 3 adds the driver.

The series is based on linux-pinctrl/for-next, as it depends on the per-SoC driver split and on the CHIP SCU lookup by "airoha,chip-scu" phandle that landed there.

Tested on a DASAN H660GM-A (EN7528, Airtel), booting OpenWrt.

Changes in v2:
- 2/3: move patternProperties after properties, and allOf to the end before additionalProperties (Krzysztof Kozlowski).
- Rebased on linux-pinctrl/for-next.
- Link to v1:
https://lore.kernel.org/linux-gpio/[email protected]/

Ahmed Naseef (2):
pinctrl: airoha: limit GPIO interrupts to interrupt-capable pins
dt-bindings: pinctrl: Add EcoNet EN7528 pin controller

Benjamin Larsson (1):
pinctrl: airoha: add support of en7528 SoC

 .../pinctrl/econet,en7528-pinctrl.yaml        |  190 +++
 drivers/pinctrl/airoha/Kconfig                |   15 +-
 drivers/pinctrl/airoha/Makefile               |    1 +
 drivers/pinctrl/airoha/airoha-common.h        |    3 +
 drivers/pinctrl/airoha/pinctrl-airoha.c       |   33 +-
 drivers/pinctrl/airoha/pinctrl-an7563.c       |    1 +
 drivers/pinctrl/airoha/pinctrl-an7581.c       |    1 +
 drivers/pinctrl/airoha/pinctrl-an7583.c       |    1 +
 drivers/pinctrl/airoha/pinctrl-en7523.c       |    1 +
 drivers/pinctrl/airoha/pinctrl-en7528.c       | 1204 +++++++++++++++++
 10 files changed, 1443 insertions(+), 7 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/pinctrl/econet,en7528-pinctrl.yaml
 create mode 100644 drivers/pinctrl/airoha/pinctrl-en7528.c

Range-diff against v1:
1: 5a7f97adbca7 ! 1: 420a5e385cf7 pinctrl: airoha: limit GPIO interrupts to interrupt-capable pins
@@ Commit message
instead of deferring the failure to request_irq().

+ Reviewed-by: Benjamin Larsson <[email protected]>

## drivers/pinctrl/airoha/airoha-common.h ##
@@ drivers/pinctrl/airoha/airoha-common.h: struct airoha_pinctrl {
2: 7e6150b186c2 ! 2: c20005a81b40 dt-bindings: pinctrl: Add EcoNet EN7528 pin controller
@@ Documentation/devicetree/bindings/pinctrl/econet,en7528-pinctrl.yaml (new)
+ '#interrupt-cells':
+ const: 2
+
-+allOf:
-+ - $ref: pinctrl.yaml#
-+
-+required:
-+ - compatible
-+ - airoha,chip-scu
-+ - interrupts
-+ - gpio-controller
-+ - gpio-ranges
-+ - "#gpio-cells"
-+ - interrupt-controller
-+ - "#interrupt-cells"
-+
+patternProperties:
+ '-pins$':
+ type: object
@@ Documentation/devicetree/bindings/pinctrl/econet,en7528-pinctrl.yaml (new)
+
+ additionalProperties: false
+
++required:
++ - compatible
++ - airoha,chip-scu
++ - interrupts
++ - gpio-controller
++ - gpio-ranges
++ - "#gpio-cells"
++ - interrupt-controller
++ - "#interrupt-cells"
++
++allOf:
++ - $ref: pinctrl.yaml#
++
+additionalProperties: false
+
+examples:
3: c3b785d8463e = 3: ea5b2ce92136 pinctrl: airoha: add support of en7528 SoC

base-commit: d067f0f4c96cb5402a111cf649b7bf9c5771ec74

Signature · 1 line
2.34.1