Skip to content

IXGBE IPsec fixes

Anatoly Burakov dpdk-dev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest7 patches 2 repliesIn review
  2. v16 patches 1 replySuperseded

Changes in v2 from the cover letter

- Added rte_memzero_explicit calls on account of AI review
- Added a small patch fixing wrong variable usage
- Reworked patch 7 (was 6) to not perform SPI byteswap until register writes

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7net/ixgbe: add key length check in IPsecdrivers/net/intel/ixgbe/ixgbe_ipsec.c+6 -00 replies
2/7net/ixgbe: remove unnecessary dev pointerdrivers/net/intel/ixgbe/ixgbe_ipsec.c+4 -50 replies
3/7net/ixgbe: harmonize return values in IPsecdrivers/net/intel/ixgbe/ixgbe_ipsec.c+12 -180 replies
4/7net/ixgbe: get rid of unnecessary malloc in IPsecdrivers/net/intel/ixgbe/ixgbe_ipsec.c+3 -130 replies
5/7net/ixgbe: use correct index variable in IPsecdrivers/net/intel/ixgbe/ixgbe_ipsec.c+1 -11 reply
6/7net/ixgbe: fix missing HW write in IPsecdrivers/net/intel/ixgbe/ixgbe_ipsec.c+1 -00 replies
7/7net/ixgbe: refactor IPsec codedrivers/net/intel/ixgbe/ixgbe_ipsec.c drivers/net/intel/ixgbe/ixgbe_ipsec.h+139 -1590 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchRadu NicolauBruce Richardson
1/7A-b
2/7A-b
3/7A-b
4/7A-b
5/7A-b
6/7A-b
7/7A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/7] IXGBE IPsec fixes

Small array of fixes and refactors for IXGBE IPsec implementation.

v1 -> v2:
- Added rte_memzero_explicit calls on account of AI review
- Added a small patch fixing wrong variable usage
- Reworked patch 7 (was 6) to not perform SPI byteswap until register writes

Anatoly Burakov (7):
net/ixgbe: add key length check in IPsec net/ixgbe: remove unnecessary dev pointer net/ixgbe: harmonize return values in IPsec net/ixgbe: get rid of unnecessary malloc in IPsec net/ixgbe: use correct index variable in IPsec net/ixgbe: fix missing HW write in IPsec net/ixgbe: refactor IPsec code

 drivers/net/intel/ixgbe/ixgbe_ipsec.c | 355 ++++++++++++--------------
 drivers/net/intel/ixgbe/ixgbe_ipsec.h |   1 +
 2 files changed, 163 insertions(+), 193 deletions(-)
Signature · 1 line
2.52.0