Skip to content

perf c2c: Add function-view stdio support and coverage

Jiebin Sun linux-perf-users lkml sashiko-reviews 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4perf c2c: Fix documented default coalesce fieldstools/perf/Documentation/perf-c2c.txt+1 -10 replies
2/4perf tests c2c: Report skip when the workload failstools/perf/tests/shell/c2c.sh+1 -00 replies
3/4perf c2c: Add stdio support for the function viewtools/perf/Documentation/perf-c2c.txt tools/perf/builtin-c2c.c tools/perf/util/c2c-function.c +1 more+90 -170 replies
4/4perf tests c2c: Add function view stdio coveragetools/perf/tests/shell/c2c.sh+113 -03 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchTianyou LiWangyang GuoNamhyung Kim
SeriesA-b
1/4R-b R-b
2/4R-b R-b
3/4R-b R-b
4/4R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/4] perf c2c: Add function-view stdio support and coverage

The recently merged function-view series added an interactive TUI for examining the c2c data as:

read-side function -> contending writer -> shared cacheline

This follow-up makes the same view available to builds without SLANG and to pipes and scripts. perf c2c report --function now implies stdio and prints the three-level hierarchy fully expanded. It requires iaddr in the coalescing fields and is rejected together with --stats.

The first two patches fix adjacent pre-existing issues: the documented default coalesce fields are stale, and a workload recording failure in the existing c2c shell test is incorrectly reported as a pass. The third patch adds the stdio function view, and the final patch adds automated coverage using a separate contended futex workload. Systems that record no contended samples report a skip for the hierarchy checks rather than a spurious failure.

This series follows the function-view work merged from:

https://lore.kernel.org/linux-perf-users/[email protected]/

The series is based on perf-tools-next commit 9453bc6a69ef ("perf vendor events arm64: Fix Tegra410 Olympus event 0x0197").

Tested with:

- SLANG and NO_SLANG=1 builds
- perf test c2c
- perf test 'import perf'
- checkpatch.pl --strict on each patch
- unresolved-symbol checks on the Python perf module

Jiebin Sun (4):
perf c2c: Fix documented default coalesce fields perf tests c2c: Report skip when the workload fails perf c2c: Add stdio support for the function view perf tests c2c: Add function view stdio coverage

 tools/perf/Documentation/perf-c2c.txt |  14 +++-
 tools/perf/builtin-c2c.c              |  85 +++++++++++++++++--
 tools/perf/tests/shell/c2c.sh         | 114 ++++++++++++++++++++++++++
 tools/perf/util/c2c-function.c        |   9 +-
 tools/perf/util/c2c.h                 |   1 +
 5 files changed, 205 insertions(+), 18 deletions(-)

base-commit: 9453bc6a69ef43755f1c28d5688cacdd69fa16bd

Signature · 1 line
2.52.0