Skip to content

btrfs: qgroup: mark qgroup inconsistent for more

Qu Wenruo linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2btrfs: reject new qgroup rescan during subvolume droppingfs/btrfs/disk-io.c fs/btrfs/qgroup.c fs/btrfs/qgroup.h+26 -10 replies
2/2btrfs: avoid long stall when dropping a non-shared large subvolumefs/btrfs/extent-tree.c fs/btrfs/qgroup.c fs/btrfs/qgroup.h+32 -00 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchBoris Burkov
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] btrfs: qgroup: mark qgroup inconsistent for more

Commit 011b46c30476 ("btrfs: skip subtree scan if it's too high to avoid low stall in btrfs_commit_transaction()") covers the most common case that can cause a long qgroup stall, where a large subtree is rescanned when dropping a snapshot.

But there are more corner cases for the same long qgroup stall:

- A qgroup rescan is queued immediately after marking inconsistent The new rescan will immediately revert the NO_ACCOUNTING flag, thus still results long qgroup stalls.

- A subvolume with no shared subtree
This can still queue a lot of workload into the current transaction.

This series covers both less-common cases.

Qu Wenruo (2):
btrfs: reject new qgroup rescan during subvolume dropping
btrfs: avoid long stall when dropping a non-shared large subvolume

 fs/btrfs/disk-io.c     |  4 ++++
 fs/btrfs/extent-tree.c | 11 +++++++++++
 fs/btrfs/qgroup.c      | 29 ++++++++++++++++++++++++++++-
 fs/btrfs/qgroup.h      | 15 +++++++++++++++
 4 files changed, 58 insertions(+), 1 deletion(-)
Signature · 1 line
2.55.0