RFC mm/huge_memory: refactor __split_huge_pmd_locked()
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 RFC Latest9 patches 0 repliesNew
- v1 RFC9 patches 3 repliesSuperseded
Changes in v2 from the cover letter
https://lore.kernel.org/linux-mm/[email protected]/#t
- Rebase onto mainline.
- Use !vma_is_mm_managed() in place of vma_is_special_huge() in patch 3.
- Use vma_has_deposited_pgtable() in patch 4, following Lance Yang's pgtable deposit cleanup.
https://lore.kernel.org/linux-mm/[email protected]/
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | mm/huge_memory: read the huge PMD entry once when splitting itmm/ | +8 | 0 replies | |
| 2/9 | mm/huge_memory: add and use huge_zero_pmd_can_split()mm/ | +23 | 0 replies | |
| 3/9 | mm/huge_memory: add and use unmap_huge_pmd_entry()mm/ | +56 | 0 replies | |
| 4/9 | mm/huge_memory: use normal_or_softleaf_folio_pmd() in the PMD split pathmm/ | +12 | 0 replies | |
| 5/9 | mm/huge_memory: dispatch on the folio when splitting a huge PMDmm/ | +2 | 0 replies | |
| 6/9 | mm/huge_memory: add and use split_huge_pmd_anon_rmap()mm/ | +47 | 0 replies | |
| 7/9 | mm/huge_memory: add struct split_pmd_statemm/ | +88 | 0 replies | |
| 8/9 | mm/huge_memory: split present and non-present huge PMDs separatelymm/ | +180 | 0 replies | |
| 9/9 | mm/huge_memory: unify the migration and device private PTE loopsmm/ | +43 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH RFC v2 0/9] mm/huge_memory: refactor __split_huge_pmd_locked()
__split_huge_pmd_locked() currently decides from the VMA -- vma_is_anonymous(), then vma_is_special_huge() (now replaced by !vma_is_mm_managed()) -- before inspecting the PMD entry, so split and zap use different classification logic. The entry itself should decide. The function also mixes the present and non-present cases, resulting in duplicated code.
This series uses the PMD entry and its folio to decide how to handle each PMD, as zap_huge_pmd() does. It separates the present and non-present paths and moves their common work into helper functions. After this change, __split_huge_pmd_locked() only selects the appropriate helper.
v1 -> v2:
https://lore.kernel.org/linux-mm/[email protected]/#t
- Rebase onto mainline.
- Use !vma_is_mm_managed() in place of vma_is_special_huge() in patch 3.
- Use vma_has_deposited_pgtable() in patch 4, following Lance Yang's pgtable deposit cleanup.
https://lore.kernel.org/linux-mm/[email protected]/
Yin Tirui (9):
mm/huge_memory: read the huge PMD entry once when splitting it mm/huge_memory: add and use huge_zero_pmd_can_split() mm/huge_memory: add and use unmap_huge_pmd_entry() mm/huge_memory: use normal_or_softleaf_folio_pmd() in the PMD split
path
mm/huge_memory: dispatch on the folio when splitting a huge PMD mm/huge_memory: add and use split_huge_pmd_anon_rmap() mm/huge_memory: add struct split_pmd_state mm/huge_memory: split present and non-present huge PMDs separately mm/huge_memory: unify the migration and device private PTE loops
mm/huge_memory.c | 525 +++++++++++++++++++++++++++-------------------- 1 file changed, 302 insertions(+), 223 deletions(-)
Signature · 1 line
2.34.1