pahole: Fix --unions bypassing the struct-only options
Status from this message: Thanks, applied!
Get series with b4
b4 am [email protected]Versions newest first
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | pahole: Fix --unions --packable segfaultpahole.c | +4 | 0 replies | |
| 2/3 | pahole: Don't match unions with --with_flexible_arraypahole.c | +2 | 0 replies | |
| 3/3 | pahole: Apply the struct-only filters to unionspahole.c | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH dwarves v2 0/3] pahole: Fix --unions bypassing the struct-only options
Split into three independent patches as you asked, so any of them can be picked up or dropped on its own:
1/3 --unions --packable segfault fix with the Fixes: tag 2/3 add flexible array options, to the struct only check 3/3 stop ignoring the struct-only filters.
v1: https://lore.kernel.org/dwarves/[email protected]/
Holes and padding in the structs inside a union can be found with 'pahole -a -A.' Details are in my reply on the v1 thread.
Would a '--recursive' modifier make sense? The hole and padding filters don't look inside member structs currently. Optionally with a depth like '--recursive=2'.
Aditya Dutt (3):
pahole: Fix --unions --packable segfault
pahole: Don't match unions with --with_flexible_array
pahole: Apply the struct-only filters to unions
pahole.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)
Signature · 1 line
2.50.1