Skip to content

media: i2c: Add missing v4l2_subdev_cleanup() calls

Aleksandr Chubuchnyi linux-media lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5media: i2c: imx296: Add missing v4l2_subdev_cleanup() calldrivers/media/i2c/imx296.c+1 -00 replies
2/5media: i2c: imx415: Add missing v4l2_subdev_cleanup() calldrivers/media/i2c/imx415.c+1 -01 reply
3/5media: i2c: mt9m114: Add missing v4l2_subdev_cleanup() callsdrivers/media/i2c/mt9m114.c+2 -00 replies
4/5media: i2c: ov8858: Add missing v4l2_subdev_cleanup() calldrivers/media/i2c/ov8858.c+2 -00 replies
5/5media: i2c: st-mipid02: Add missing v4l2_subdev_cleanup() calldrivers/media/i2c/st-mipid02.c+2 -01 reply

Reviews trailers per patch

2 of 5 patches have a Reviewed-by or Acked-by.

PatchMichael RieschBenjamin Mugnier
1/5
2/5R-b
3/5
4/5
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] media: i2c: Add missing v4l2_subdev_cleanup() calls

v4l2_subdev_init_finalize() allocates the subdev active state and only v4l2_subdev_cleanup() frees it. These five drivers never call it, so they leak the state on every unbind.

Separate patches because the Fixes tags span 2022 to 2023 and go to different stable trees. The st-mipid02 one dates from the active state conversion, not from the original driver.

Aleksandr Chubuchnyi (5):
media: i2c: imx296: Add missing v4l2_subdev_cleanup() call
media: i2c: imx415: Add missing v4l2_subdev_cleanup() call
media: i2c: mt9m114: Add missing v4l2_subdev_cleanup() calls
media: i2c: ov8858: Add missing v4l2_subdev_cleanup() call
media: i2c: st-mipid02: Add missing v4l2_subdev_cleanup() call

 drivers/media/i2c/imx296.c     | 1 +
 drivers/media/i2c/imx415.c     | 1 +
 drivers/media/i2c/mt9m114.c    | 2 ++
 drivers/media/i2c/ov8858.c     | 2 ++
 drivers/media/i2c/st-mipid02.c | 2 ++
 5 files changed, 8 insertions(+)
Signature · 1 line
2.43.0