Skip to content

mgmt-tester: fix test failures + avoid hidden skipping

Pauli Virtanen linux-bluetooth 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5mgmt-tester: ignore Debug feature in Read Exp Feature teststest/functional/test_kernel_testers.py tools/mgmt-tester.c+89 -232 replies
2/5mgmt-tester: Fix expected status for invalid key entriestools/mgmt-tester.c+11 -30 replies
3/5mgmt-tester: mark Pair Device - Power off 1 as fail_toleranttools/mgmt-tester.c+6 -00 replies
4/5mgmt-tester: Report unexpected status as test failuretools/mgmt-tester.c+6 -10 replies
5/5shared/tester: Count setup failures as test failuressrc/shared/tester.c+3 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH BlueZ 0/5] mgmt-tester: fix test failures + avoid hidden skipping

MGMT tests have one failure + 4 hidden failures:

Load Link Keys - Invalid Parameters 3                Not Run
Load Long Term Keys - Invalid Parameters 2           Not Run
Load Long Term Keys - Invalid Parameters 3           Not Run
Pair Device - Power off 1                            Not Run
Read Exp Feature - Success                           Failed

These fail because:

- Invalid Parameters: change in MGMT semantics in 2024, test wasn't updated

- Pair Device - Power off 1: race between MGMT and ioctl, let's just ignore, it is not deterministic

- Read Exp Feature - Success: simple test issue vs. Debug extension

Fix these, and make it reports failures correctly.

Adjust the test machinery reporting of setup failures, to avoid some additional paths to "Not Run" reporting.

LLM used for triage + fixing issues, except where it needed manual cleanup for simpler solution. I reviewed all commits.

Assisted-by opencode:qwen3.8-next-flash

Pauli Virtanen (5):
mgmt-tester: ignore Debug feature in Read Exp Feature tests
mgmt-tester: Fix expected status for invalid key entries
mgmt-tester: mark Pair Device - Power off 1 as fail_tolerant
mgmt-tester: Report unexpected status as test failure shared/tester: Count setup failures as test failures

 src/shared/tester.c                    |   3 +
 test/functional/test_kernel_testers.py |   2 -
 tools/mgmt-tester.c                    | 137 ++++++++++++++++++++-----
 3 files changed, 115 insertions(+), 27 deletions(-)
Signature · 1 line
2.55.0