ibmveth: fix open-fail unwind after LAN registration
Status from this message: This series was applied to netdev/net.git (main)
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 All 2 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | ibmveth: h_free logical LAN on open-fail after registerdrivers/ | +3 | 3 replies | Applied |
| 2/2 | ibmveth: fix TX LTB and filter unwind on open-faildrivers/ | +9 | 1 reply | Applied |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Dave Marquardt |
|---|---|
| 1/2 | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net 0/2] ibmveth: fix open-fail unwind after LAN registration
Hi,
ibmveth_open() has two independent unwind holes after the logical LAN is set up. Neither needs the MQ RX series. This posting is against current net.git.
Patch 1 issues h_free_logical_lan() on every post-register failure. A pool allocation failure jumped to out_free_buffer_pools without the hypercall, so PHYP still owned the buffer-list page when it was unmapped. request_irq() failure already issued H_FREE before taking the same label.
Patch 2 gives TX LTBs their own walk. out_free_buffer_pools reuses open()'s loop index, so after the pool unwind i is -1 and the TX buffers leak. request_irq() failure has the same leak. The TX-fail goto on that walk also skips dma_unmap of the filter list (pre-existing since the LTB was added).
The MQ RX series on net-next keeps the helper versions of these guards and does not depend on this pair. If both land, keep the helpers in that series; these two patches are the current single-queue open-fail path only.
Mingming
Mingming Cao (2):
ibmveth: h_free logical LAN on open-fail after register
ibmveth: fix TX LTB and filter unwind on open-fail
drivers/net/ethernet/ibm/ibmveth.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-)
base-commit: 11536ee3d3e0b1bd35b6f3f8df55a6053eb0c71d
Signature · 1 line
2.50.1 (Apple Git-155)