Rust VFIO PCI support and NVIDIA vGPU driver
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest7 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | rust: pci: add VFIO override device IDsrust/ | +7 | 0 replies | |
| 2/7 | rust: pci: expose the VF index within its PFrust/ | +8 | 1 reply | |
| 3/7 | rust: pci: allow drivers to manage DMA ownershiprust/ | +4 | 0 replies | |
| 4/7 | rust: vfio: add PCI variant driver abstractionsrust/ rust/ rust/ +1 more | +1215 | 1 reply | |
| 5/7 | rust: vfio: separate common device handling from PCIrust/ rust/ | +263 | 0 replies | |
| 6/7 | gpu: nova-core: publish typed SR-IOV PF APIsdrivers/ drivers/ drivers/ | +130 | 0 replies | |
| 7/7 | vfio/nvidia-vgpu: add the Rust VFIO variant driverdrivers/ drivers/ drivers/ +3 more | +405 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/7] Rust VFIO PCI support and NVIDIA vGPU driver
This series adds Rust support for VFIO PCI variant drivers and an NVIDIA vGPU driver using Nova's typed SR-IOV PF services.
It follows the discussion of the original C NVIDIA vGPU VFIO variant [1] and builds on Danilo Krummrich's Rust vGPU/VFIO proof of concept [2], including his PCI helpers, VFIO abstractions and NVIDIA variant driver. Keeping the variant in Rust preserves the ownership and lifetime relationships with nova-core across the PF/VF interface, and allows registration and first-open/last-close resources to use Rust's RAII model.
The VFIO core prerequisite is the work of Simon Song and Alex Williamson, discussed in [3]. VFIO core previously required PCI driver data to point directly to a vfio_pci_core_device, conflicting with Rust's typed private data. Their changes let each driver's PM, AER and VGA callbacks recover the core device from its own private data and pass it to shared VFIO helpers. This addresses the concern raised in the earlier thread: the Rust driver can retain its typed PCI private data without adding a separate VFIO pointer to struct pci_dev.
The main changes from the PoC are:
- Separate common VFIO device and callback-data handling from the PCI wrapper. Require covariant registration data when restoring erased lifetimes, keep callback borrows distinct from data lifetimes, and extend callback-scoped access to open, write and mmap.
- Add a VFIO PCI adapter for PM, AER, reset and VGA callbacks. Register VFIO after publishing initialized PCI private data, and unregister before releasing that data.
- Connect the typed PF instance handle to the existing Nova manager's implemented open, close and reset operations. Make PF service access fallible and reject PCI segments that do not fit the firmware's DBDF format.
- Match all NVIDIA device IDs and classes through an override-only entry, with PCI passthrough for devices without Nova services. Wire up IOMMUFD PASID callbacks and passthrough BAR DMA-buffer operations.
- Enforce the assigned BAR1 aperture for read, write and mmap as well as region-info queries. Set the guest device ID in VFIO's virtual configuration space and retain the subsystem-ID read override.
Integration branch:
https://github.com/zhiwang-nvidia/nova-core/tree/zhi/nova-vgpu-20260930
[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/nova-gpu/[email protected]/
[3] https://lore.kernel.org/all/[email protected]/
Danilo Krummrich (5):
rust: pci: add VFIO override device IDs
rust: pci: expose the VF index within its PF
rust: pci: allow drivers to manage DMA ownership
rust: vfio: add PCI variant driver abstractions vfio/nvidia-vgpu: add the Rust VFIO variant driver
Zhi Wang (2):
rust: vfio: separate common device handling from PCI
gpu: nova-core: publish typed SR-IOV PF APIs
drivers/gpu/Makefile | 15 +- drivers/gpu/nova-core/driver.rs | 47 + drivers/gpu/nova-core/nova_core.rs | 2 + drivers/gpu/nova-core/vgpu/vgpu_api.rs | 82 +- drivers/vfio/pci/Kconfig | 2 + drivers/vfio/pci/Makefile | 2 + drivers/vfio/pci/nvidia-vgpu/Kconfig | 20 + drivers/vfio/pci/nvidia-vgpu/Makefile | 3 + drivers/vfio/pci/nvidia-vgpu/nvidia_vgpu.rs | 366 +++++++ rust/bindings/bindings_helper.h | 4 + rust/kernel/lib.rs | 2 + rust/kernel/pci.rs | 11 + rust/kernel/pci/iov.rs | 8 + rust/kernel/vfio.rs | 290 ++++++ rust/kernel/vfio/pci.rs | 1038 +++++++++++++++++++ 15 files changed, 1888 insertions(+), 4 deletions(-) create mode 100644 drivers/vfio/pci/nvidia-vgpu/Kconfig create mode 100644 drivers/vfio/pci/nvidia-vgpu/Makefile create mode 100644 drivers/vfio/pci/nvidia-vgpu/nvidia_vgpu.rs create mode 100644 rust/kernel/vfio.rs create mode 100644 rust/kernel/vfio/pci.rs
base-commit: 808dda6545c8775ea0abce0490308ddfeb5b8178
Signature · 1 line
2.53.0