Input: hynitron-cst816x: axes and gesture keys
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest5 patches 3 repliesIn review
- v34 patches 1 replySuperseded
- v25 patches 6 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 4 patches | 1 reply | Superseded |
Changes in v4 from the cover letter
- patch 5 is new: INPUT_PROP_DIRECT marks the sensor as overlaying the display, which userspace otherwise has to deduce from the event types it emits
- a key is reported only for the gesture codes the binding names, as the controller also sends single click, which aliased onto the long-press keycode on a CST816S (Oleh Kuzhylnyi)
- the release loop reads each keycode once, so the key it tests is the key it releases (Sashiko AI review)
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | dt-bindings: input: touchscreen: hynitron,cst816x: axes and panelDocumentation/ | +5 | 1 reply | |
| 2/5 | Input: hynitron-cst816x: respect touchscreen DT propertiesdrivers/ | +5 | 0 replies | |
| 3/5 | Input: hynitron-cst816x: release gesture keysdrivers/ | +55 | 1 reply | |
| 4/5 | Input: hynitron-cst816x: time out gesture key releasedrivers/ | +49 | 1 reply | |
| 5/5 | Input: hynitron-cst816x: set INPUT_PROP_DIRECTdrivers/ | +1 | 0 replies |
Reviews trailers per patch
None of the 5 patches has a Reviewed-by or Acked-by.
| Patch | Oleh Kuzhylnyi |
|---|---|
| 1/5 | |
| 2/5 | |
| 3/5 | T-b |
| 4/5 | T-b |
| 5/5 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/5] Input: hynitron-cst816x: axes and gesture keys
This series improves the hynitron-cst816x touchscreen driver. It makes the driver respect the common touchscreen axis properties, which the binding now describes along with the rest of touchscreen.yaml, and it keeps gesture keys from getting stuck. It also marks the sensor as mapping straight onto the display.
The gesture key is reported with the controller's touch flag as its value, so the key stays pressed once the controller stops reporting the gesture code. The controller has no lift event to offer, so the keys are now released on the first report carrying no gesture code, or 40 ms after the last one that carried a code, whichever comes first.
Changes since v3:
- patch 5 is new: INPUT_PROP_DIRECT marks the sensor as overlaying the display, which userspace otherwise has to deduce from the event types it emits
- a key is reported only for the gesture codes the binding names, as the controller also sends single click, which aliased onto the long-press keycode on a CST816S (Oleh Kuzhylnyi)
- the release loop reads each keycode once, so the key it tests is the key it releases (Sashiko AI review)
Changes since v2:
- the binding describes the whole of touchscreen.yaml through unevaluatedProperties (Krzysztof Kozlowski)
- the panel follower patch is dropped. It serves a panel that registers a drm_panel, while a MIPI DBI display driven by panel-mipi-dbi owns the DRM device itself and registers none, so on such a board the lookup defers for ever and the touchscreen never probes. The 'panel' phandle stays described in the binding
- the release timer is stopped with timer_shutdown_sync() in the devres action (Sashiko AI review)
Changes since v1:
- the binding allows touchscreen-min-x/y, touchscreen-size-x/y and touchscreen-fuzz-x/y as well, which touchscreen_parse_properties() already honours; the 240x240 default is unchanged
- the binding allows the 'panel' phandle, and patch 5 is new: it follows the panel's power sequence
- the binding commit message carries a justification (Conor Dooley)
- keycodes above KEY_MAX are rejected, which keeps the gesture key lookup inside the input core's key bitmap (Sashiko AI review)
- the timed release is skipped when the interrupt handler re-armed the timer while the timer callback waited for the lock (Sashiko AI review)
- the Sashiko AI review also asked about additionalProperties next to a $ref, which stays, as this binding allows a subset of touchscreen.yaml (writing-schema.rst)
Daniel Golle (5):
dt-bindings: input: touchscreen: hynitron,cst816x: axes and panel
Input: hynitron-cst816x: respect touchscreen DT properties
Input: hynitron-cst816x: release gesture keys
Input: hynitron-cst816x: time out gesture key release
Input: hynitron-cst816x: set INPUT_PROP_DIRECT
.../input/touchscreen/hynitron,cst816x.yaml | 6 +- drivers/input/touchscreen/hynitron-cst816x.c | 141 +++++++++++++----- 2 files changed, 112 insertions(+), 35 deletions(-)
base-commit: 6474fa070f2b8013b4b87350b775b8c3be6e8aac
Signature · 1 line
2.56.0