Skip to content

Backport of XFS umount hang fixes

Siddh Raman Pant linux-xfs lkml stable 9 versions – Applied

Status from this message: Queued the series for 5.10, thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest posting 8/819 patches 3 repliesApplied
  2. v2 posting 7/89 patches 1 replyApplied
  3. v2 posting 6/85 patches 1 replyApplied
Earlier versions · 6
VersionPostedPatchesRepliesStatus
v2 posting 5/85 patches5 repliesApplied
v2 posting 4/86 patches2 repliesApplied
v2 posting 3/819 patches0 repliesSuperseded
v2 posting 2/85 patches2 repliesSuperseded
v2 posting 1/86 patches0 repliesSuperseded
v121 patches0 repliesSuperseded

Patches in v2 posting 8/8 Applied

#Subject and filesSizeRepliesApplied
1/19xfs: hoist recovered bmap intent checks out of xfs_bui_item_recoverfs/xfs/xfs_bmap_item.c+47 -270 replies
2/19xfs: improve the code that checks recovered bmap intent itemsfs/xfs/xfs_bmap_item.c+13 -130 replies
3/19xfs: hoist recovered rmap intent checks out of xfs_rui_item_recoverfs/xfs/xfs_rmap_item.c+42 -250 replies
4/19xfs: improve the code that checks recovered rmap intent itemsfs/xfs/xfs_rmap_item.c+18 -120 replies
5/19xfs: hoist recovered refcount intent checks out of xfs_cui_item_recoverfs/xfs/xfs_refcount_item.c+38 -210 replies
6/19xfs: improve the code that checks recovered refcount intent itemsfs/xfs/xfs_refcount_item.c+11 -120 replies
7/19xfs: don't nest icloglock inside ic_callback_lockfs/xfs/xfs_log.c+4 -140 replies
8/19xfs: convert XLOG_FORCED_SHUTDOWN() to xlog_is_shutdown()fs/xfs/xfs_log.c fs/xfs/xfs_log_cil.c fs/xfs/xfs_log_priv.h +2 more+29 -290 replies
9/19xfs: log items should have a xlog pointer, not a mountfs/xfs/xfs_bmap_item.c fs/xfs/xfs_buf_item.c fs/xfs/xfs_dquot_item.c +8 more+17 -140 replies
10/19xfs: aborting inodes on shutdown may need buffer lockfs/xfs/xfs_icache.c fs/xfs/xfs_inode.c fs/xfs/xfs_inode_item.c +1 more+137 -320 replies
11/19xfs: remove xfs_buf_t typedeffs/xfs/libxfs/xfs_alloc.c fs/xfs/libxfs/xfs_bmap.c fs/xfs/libxfs/xfs_btree.c +13 more+80 -800 replies
12/19xfs: fix super block buf log item UAF during force shutdownfs/xfs/xfs_buf_item.c+2 -00 replies
13/19xfs: fix intermittent hang during quotacheckfs/xfs/xfs_qm.c+7 -00 replies
14/19xfs: buffer pins need to hold a buffer referencefs/xfs/xfs_buf_item.c+65 -230 replies
15/19xfs: xfs_ifree_cluster vs xfs_iflush_shutdown_abort deadlockfs/xfs/xfs_icache.c fs/xfs/xfs_inode.c+10 -10 replies
16/19xfs: catch stale AGF/AGF metadatafs/xfs/libxfs/xfs_alloc.c fs/xfs/libxfs/xfs_ialloc.c+64 -150 replies
17/19xfs: rearrange code in xfs_buf_item.cfs/xfs/xfs_buf_item.c fs/xfs/xfs_buf_item.h+60 -590 replies
18/19xfs: factor out stale buffer item completionfs/xfs/xfs_buf_item.c+37 -230 replies
19/19xfs: fix unmount hang with unflushable inodes stuck in the AILfs/xfs/xfs_buf_item.c fs/xfs/xfs_buf_item.h+87 -380 replies

Reviews trailers per patch

All 19 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchChristoph HellwigBrian FosterDarrick J. WongChandan Babu RDave ChinnerCarlos Maiolino
SeriesA-b
1/19R-b R-b
2/19R-b R-b
3/19R-b R-b
4/19R-b
5/19R-b R-b
6/19R-b R-b
7/19R-b R-b
8/19R-b R-b
9/19R-b R-b
10/19R-b
11/19R-b R-b
12/19R-b A-b
13/19A-b R-b
14/19R-b R-b A-b
15/19R-b R-b
16/19R-b
17/19R-b
18/19R-b
19/19R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 6 reviewers.

Read the v2 thread

Cover letter [PATCH RESEND 5.10 v2 00/19] Backport of XFS umount hang fixes

Backport of this series:
https://lore.kernel.org/all/[email protected]/

I have added information in commit message upon conflict resolutions.

v2: Address Sasha's comments to v1 in the below mail:
https://lore.kernel.org/stable/2026-10-01-1-daily-reply-0012-re-xfs-umount-hang-backports@kernel.org/

Thanks,
Siddh

Darrick J. Wong (7):
xfs: hoist recovered bmap intent checks out of xfs_bui_item_recover
xfs: improve the code that checks recovered bmap intent items
xfs: hoist recovered rmap intent checks out of xfs_rui_item_recover
xfs: improve the code that checks recovered rmap intent items
xfs: hoist recovered refcount intent checks out of
xfs_cui_item_recover
xfs: improve the code that checks recovered refcount intent items
xfs: fix intermittent hang during quotacheck

Dave Chinner (11):
xfs: don't nest icloglock inside ic_callback_lock
xfs: convert XLOG_FORCED_SHUTDOWN() to xlog_is_shutdown()
xfs: log items should have a xlog pointer, not a mount
xfs: aborting inodes on shutdown may need buffer lock
xfs: remove xfs_buf_t typedef
xfs: buffer pins need to hold a buffer reference
xfs: xfs_ifree_cluster vs xfs_iflush_shutdown_abort deadlock
xfs: catch stale AGF/AGF metadata
xfs: rearrange code in xfs_buf_item.c
xfs: factor out stale buffer item completion
xfs: fix unmount hang with unflushable inodes stuck in the AIL

Guo Xuenan (1):
xfs: fix super block buf log item UAF during force shutdown

 fs/xfs/libxfs/xfs_alloc.c    |  61 ++++--
 fs/xfs/libxfs/xfs_bmap.c     |   6 +-
 fs/xfs/libxfs/xfs_btree.c    |  10 +-
 fs/xfs/libxfs/xfs_ialloc.c   |  38 +++-
 fs/xfs/libxfs/xfs_rtbitmap.c |  22 +-
 fs/xfs/xfs_bmap_item.c       |  76 ++++---
 fs/xfs/xfs_buf.c             |  24 +--
 fs/xfs/xfs_buf.h             |  14 +-
 fs/xfs/xfs_buf_item.c        | 384 ++++++++++++++++++++++-------------
 fs/xfs/xfs_buf_item.h        |   3 +-
 fs/xfs/xfs_dquot_item.c      |   5 +-
 fs/xfs/xfs_extfree_item.c    |   2 +-
 fs/xfs/xfs_fsops.c           |   2 +-
 fs/xfs/xfs_icache.c          |  10 +-
 fs/xfs/xfs_inode.c           |   9 +-
 fs/xfs/xfs_inode_item.c      | 164 ++++++++++++---
 fs/xfs/xfs_inode_item.h      |   1 +
 fs/xfs/xfs_log.c             |  50 ++---
 fs/xfs/xfs_log_cil.c         |  12 +-
 fs/xfs/xfs_log_priv.h        |   7 +-
 fs/xfs/xfs_log_recover.c     |  17 +-
 fs/xfs/xfs_qm.c              |   7 +
 fs/xfs/xfs_refcount_item.c   |  60 ++++--
 fs/xfs/xfs_rmap_item.c       |  75 ++++---
 fs/xfs/xfs_rtalloc.c         |  20 +-
 fs/xfs/xfs_rtalloc.h         |   4 +-
 fs/xfs/xfs_symlink.c         |   4 +-
 fs/xfs/xfs_trace.h           |   4 +-
 fs/xfs/xfs_trans.c           |   6 +-
 fs/xfs/xfs_trans.h           |   3 +-
 fs/xfs/xfs_trans_buf.c       |  16 +-
 31 files changed, 723 insertions(+), 393 deletions(-)
Signature · 1 line
2.53.0