Skip to content

net/intel: make link state configurable on device start

Roman Khromenok dpdk-dev 1 version NAK

Status from this message: NAK.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesNAK

Patches in v1

#Subject and filesSizeRepliesApplied
1/3net/ice: make link state configurable on device startdoc/guides/nics/ice.rst doc/guides/rel_notes/release_26_11.rst drivers/net/intel/ice/ice_ethdev.c +1 more+50 -20 replies
2/3net/i40e: make link state configurable on device startdoc/guides/nics/i40e.rst doc/guides/rel_notes/release_26_11.rst drivers/net/intel/i40e/i40e_ethdev.c +1 more+76 -20 replies
3/3net/ixgbe: make link state configurable on device startdoc/guides/nics/ixgbe.rst doc/guides/rel_notes/release_26_11.rst drivers/net/intel/ixgbe/ixgbe_ethdev.c +1 more+61 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] net/intel: make link state configurable on device start

Starting a port always brings its link up, so the link partner sees the port as soon as the application starts it. An application that enables ports only after its own configuration is applied, such as a firewall or a switch, cannot keep a disabled port dark: it can only bring the link down right after rte_eth_dev_start(), and the link partner may still see the link flap.

The ice driver already has the link_state_on_close device argument to choose the link state when the port is stopped. This series adds its counterpart, link_state_on_start, to the ice, i40e and ixgbe drivers:

-a <pci>,link_state_on_start=down

With "down", the port is started with the link down, and the application brings it up later with rte_eth_dev_set_link_up(). The default "up" keeps the current behavior.

ixgbe has no firmware command to bring the link down, so "down" leaves the port in the same state as rte_eth_dev_set_link_down(): the laser is kept off on fiber links, the copper PHY is powered off right after the link setup.

Tested with testpmd on E810-C (ice, firmware 4.60) connected to a network packet broker: with link_state_on_start=down the link stays down after the port start and the link partner does not see it until "set link-up"; without the device argument the link comes up on start as before. i40e and ixgbe are build tested only.

Roman Khromenok (3):
net/ice: make link state configurable on device start net/i40e: make link state configurable on device start net/ixgbe: make link state configurable on device start

 doc/guides/nics/i40e.rst               | 13 ++++++
 doc/guides/nics/ice.rst                | 13 ++++++
 doc/guides/nics/ixgbe.rst              | 13 ++++++
 doc/guides/rel_notes/release_26_11.rst | 13 +++++-
 drivers/net/intel/i40e/i40e_ethdev.c   | 58 +++++++++++++++++++++++++-
 drivers/net/intel/i40e/i40e_ethdev.h   |  2 +
 drivers/net/intel/ice/ice_ethdev.c     | 36 +++++++++++++++-
 drivers/net/intel/ice/ice_ethdev.h     |  1 +
 drivers/net/intel/ixgbe/ixgbe_ethdev.c | 44 ++++++++++++++++++-
 drivers/net/intel/ixgbe/ixgbe_ethdev.h |  2 +
 10 files changed, 187 insertions(+), 8 deletions(-)
Signature · 1 line
2.47.3