Skip to content

btrfs-progs: check: fix and refactor load_quota_info()

Qu Wenruo linux-btrfs 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4btrfs-progs: check: fix the inverted condition to load qgroupscheck/qgroup-verify.c+1 -10 replies
2/4btrfs-progs: check: remove unused qgroup_count::keycheck/qgroup-verify.c+0 -20 replies
3/4btrfs-progs: check: refactor load_quota_info()check/qgroup-verify.c+75 -780 replies
4/4btrfs-progs: fsck-tests: add a new test case for qgroup tree checktests/fsck-tests/076-large-quota-tree/test.sh+28 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] btrfs-progs: check: fix and refactor load_quota_info()

The btrfs-check code of qgroup verification is pretty old, and there is a long existing bug from day 1 that causes incorrect initial search condition.

The first patch is to fix that bug.

Then the second one to reduce the memory usage of qgroup_count structure.

The third one is to refactor load_quota_info() to follow the modern standard and practice.

Finally add a test case as a regression test.

Qu Wenruo (4):
btrfs-progs: check: fix the inverted condition to load qgroups
btrfs-progs: check: remove unused qgroup_count::key
btrfs-progs: check: refactor load_quota_info()
btrfs-progs: fsck-tests: add a new test case for qgroup tree check

 check/qgroup-verify.c                         | 155 +++++++++---------
 tests/fsck-tests/076-large-quota-tree/test.sh |  28 ++++
 2 files changed, 103 insertions(+), 80 deletions(-)
 create mode 100644 tests/fsck-tests/076-large-quota-tree/test.sh

--
2.55.0