Skip to content

mlxsw: Fix port range register leak

Petr Machata netdev 1 version Applied

Status from this message: This series was applied to netdev/net.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesApplied 2/2

Patches in v1 All 2 applied

#Subject and filesSizeRepliesApplied
1/2mlxsw: spectrum_flower: Fix port range register leak in tmplt_create()drivers/net/ethernet/mellanox/mlxsw/spectrum.h drivers/net/ethernet/mellanox/mlxsw/spectrum_acl.c drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c+17 -41 replyApplied
2/2selftests: mlxsw: Test port range occupancy on template createtools/testing/selftests/drivers/net/mlxsw/port_range_occ.sh+26 -01 replyApplied

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchIdo SchimmelJacob Keller
1/2R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH net 0/2] mlxsw: Fix port range register leak

When the mlxsw driver parses a port range template rule, it acquires the actual port range registers. The parsing is only done to determine the element usage, so the registers can be deallocated right away, but this is never done, and the registers are leaked. Plug this leak and add a selftest that would have caught it.

Petr Machata (2):
mlxsw: spectrum_flower: Fix port range register leak in tmplt_create()
selftests: mlxsw: Test port range occupancy on template create

 .../net/ethernet/mellanox/mlxsw/spectrum.h    |  2 ++
 .../ethernet/mellanox/mlxsw/spectrum_acl.c    | 10 +++++--
 .../ethernet/mellanox/mlxsw/spectrum_flower.c |  9 +++++--
 .../drivers/net/mlxsw/port_range_occ.sh       | 26 +++++++++++++++++++
 4 files changed, 43 insertions(+), 4 deletions(-)
Signature · 1 line
2.55.0