net/ice: fix memory handling issues
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | net/ice: free memory with matching allocatordrivers/ drivers/ drivers/ +3 more | +29 | 1 reply | |
| 2/2 | net/ice: fix unchecked Tx time context allocationdrivers/ | +4 | 0 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Anatoly Burakov | Bruce Richardson |
|---|---|---|
| 1/2 | A-b | |
| 2/2 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] net/ice: fix memory handling issues
This patch series addresses two memory handling issues in the ice PMD.
- The first one makes memory allocation and release symmetric. Several buffers obtained through ice_malloc(), ice_calloc() or ice_memdup() were released with rte_free() instead of ice_free(). Both APIs currently map to the same underlying allocator. However, mixing them is inconsistent and would break if the OS abstraction layer ever changes.
- The second one fixes an unchecked allocation in ice_tx_queue_start() which dereferences the Tx time queue context buffer returned by ice_malloc() without NULL check.
On allocation failure, the E830 send-on-timestamp path therefore crashes instead of reporting "No Memory" error, and also the already allocated txq_elem buffer gets leaked.
Anurag Mandal (2):
net/ice: free memory with matching allocator net/ice: fix unchecked Tx time context allocation
drivers/net/intel/ice/ice_acl_filter.c | 10 +++++----- drivers/net/intel/ice/ice_dcf.c | 2 +- drivers/net/intel/ice/ice_dcf_parent.c | 2 +- drivers/net/intel/ice/ice_ethdev.c | 14 +++++++------- drivers/net/intel/ice/ice_fdir_filter.c | 12 ++++++------ drivers/net/intel/ice/ice_rxtx.c | 22 +++++++++++++--------- 6 files changed, 33 insertions(+), 29 deletions(-)
Signature · 1 line
2.34.1