Skip to content

net: enetc: S32N79 pseudo-MAC (PPM) networking support

Claudiu Manoil imx linux-arm-kernel linux-devicetree linux-pci lkml netdev 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest6 patches 0 repliesNew
  2. v35 patches 2 repliesSuperseded
  3. v25 patches 5 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v15 patches6 repliesSuperseded

Changes in v4 from the cover letter

- Patch 1: made NXP_ENETC4 depend on OF, as OF_DYNAMIC is only available with OF; improved the commit message.
- Patch 2: new, allocates the int_vector array dynamically to prevent an out-of-bounds access on S32N79.
- Patch 3: clarified the commit message.
- Patches 4-6: no changes.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6net: enetc: Add pseudo-MAC support for ENETCv4 Ports via a fixed-link nodedrivers/net/ethernet/freescale/enetc/Kconfig drivers/net/ethernet/freescale/enetc/enetc4_pf.c drivers/net/ethernet/freescale/enetc/enetc_pf.h +2 more+146 -90 replies
2/6net: enetc: Allocate int_vector array dynamicallydrivers/net/ethernet/freescale/enetc/enetc.c drivers/net/ethernet/freescale/enetc/enetc.h+9 -20 replies
3/6net: enetc: Enable probing of version 4.4 devicesdrivers/net/ethernet/freescale/enetc/enetc.c drivers/net/ethernet/freescale/enetc/enetc_hw.h+29 -10 replies
4/6arm64: dts: s32n79: add NETC IEP18 ECAM node for ENETC PPM portsarch/arm64/boot/dts/freescale/s32n79.dtsi+24 -00 replies
5/6arm64: dts: s32n79-rdb: enable NETC IEP18arch/arm64/boot/dts/freescale/s32n79-rdb.dts+4 -00 replies
6/6PCI: Create OF node for NXP ENETC pseudo-MAC functionsdrivers/pci/quirks.c+2 -00 replies

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by.

PatchBjorn Helgaas
1/6
2/6
3/6
4/6
5/6
6/6A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH net-next v4 0/6] net: enetc: S32N79 pseudo-MAC (PPM) networking support

This series adds networking support for the ENETCv4.4 pseudo-MAC (PPM) ports found on the NXP S32N79 SoC. On S32N79, the ENETCv4 ports are not wired to any external PHY/MII; instead they are internal "pseudo-MAC" links into the on-chip NETC switch. These links are proprietary, expose no standard IEEE interface, and run at a speed fixed at boot time by the Port PCR[PSPEED] register.

A key use case is a port that has no "ethernet" DT node at all: NETC is reached over PCI from a host that probes the ENETC, while the internal NETC switch it connects to is not owned by Linux. Such a port must have its fixed link synthesized at probe time.

The driver synthesizes the fixed link directly in C using an of_changeset:
of_changeset_create_node() adds a "fixed-link" subnode onto the PCI function's dynamic OF node (CONFIG_PCI_DYNAMIC_OF_NODES), with the "speed" property read from PCR[PSPEED] at probe time and "full-duplex" set. phylink then picks up the fixed-link node through dev_fwnode().

The series touches three subsystems:
- net/enetc: pseudo-MAC fixed-link support, probing of 4.4 devices and a fix for more than 6 ring interrupt vectors
- arm64 dts: NETC IEP18 ECAM node on S32N79 and its RDB board enable
- PCI: a quirk creating the OF node for the ENETC PMAC functions

Because this is primarily a networking feature and the pieces are interdependent at runtime, it would be most convenient to merge the whole series through the netdev tree.

Patch 1 has a runtime (not Kconfig) dependency on CONFIG_PCI_DYNAMIC_OF_NODES; absent that, the pseudo-MAC probe path fails gracefully with -ENODEV.

v4:
- Patch 1: made NXP_ENETC4 depend on OF, as OF_DYNAMIC is only available with OF; improved the commit message.
- Patch 2: new, allocates the int_vector array dynamically to prevent an out-of-bounds access on S32N79.
- Patch 3: clarified the commit message.
- Patches 4-6: no changes.
v3:
- Patch 1: fixed the CONFIG_OF_DYNAMIC dependency, refactored enetc4_add_ppm_fixed_link() as per Wei's feedback, and improved the commit message.
- Patch 3: added sysclk_freq info for the v4.4 ENETC devices.
- Patches 4-6: no changes.
v2:
- Switched the fixed-link patch from a DT overlay blob (of_overlay_fdt_apply() + a .dtso compiled to .dtbo) to of_changeset_create_node(), per review feedback. This drops the embedded overlay externs, the Makefile .dtbo wrapping, and the OF_OVERLAY Kconfig dependency. The operating speed is now baked directly into the changeset-created fixed-link node (read once from PCR[PSPEED] at probe time); the phylink get_fixed_state callback is no longer needed and was removed.
- Described why there are two ENETC PF IDs in the commit message, as per review.
- Replaced the 'msi-parent' stub property with 'msi-map', as per H/W spec.
- Reworded the PCI patch commit message to match the fixed-link approach (no functional change); added Bjorn's Acked-by.
v1: initial submission.

Claudiu Manoil (6):
net: enetc: Add pseudo-MAC support for ENETCv4 Ports via a fixed-link
node
net: enetc: Allocate int_vector array dynamically
net: enetc: Enable probing of version 4.4 devices
arm64: dts: s32n79: add NETC IEP18 ECAM node for ENETC PPM ports
arm64: dts: s32n79-rdb: enable NETC IEP18
PCI: Create OF node for NXP ENETC pseudo-MAC functions

 arch/arm64/boot/dts/freescale/s32n79-rdb.dts  |   4 +
 arch/arm64/boot/dts/freescale/s32n79.dtsi     |  24 ++++
 drivers/net/ethernet/freescale/enetc/Kconfig  |   2 +
 drivers/net/ethernet/freescale/enetc/enetc.c  |  34 ++++++
 drivers/net/ethernet/freescale/enetc/enetc.h  |   3 +-
 .../net/ethernet/freescale/enetc/enetc4_pf.c  | 109 +++++++++++++++++-
 .../net/ethernet/freescale/enetc/enetc_hw.h   |   4 +-
 .../net/ethernet/freescale/enetc/enetc_pf.h   |   2 +
 .../freescale/enetc/enetc_pf_common.c         |  41 ++++++-
 .../freescale/enetc/enetc_pf_common.h         |   1 +
 drivers/pci/quirks.c                          |   2 +
 11 files changed, 214 insertions(+), 12 deletions(-)
Signature · 1 line
2.34.1