Skip to content

IAVF Fixes

Anatoly Burakov dpdk-dev 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest10 patches 2 repliesIn review
  2. v410 patches 8 repliesSuperseded
  3. v310 patches 2 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v29 patches1 replySuperseded
v17 patches2 repliesSuperseded

Changes in v5 from the cover letter

- Dropped the unnecessary EFD disable from patch 4

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10net/iavf: keep device stopped if start failsdrivers/net/intel/iavf/iavf_ethdev.c+4 -50 replies
2/10net/iavf: do not store ethdev pointerdrivers/net/intel/iavf/iavf.h drivers/net/intel/iavf/iavf_ethdev.c drivers/net/intel/iavf/iavf_ipsec_crypto.c +2 more+30 -250 replies
3/10net/iavf: fix false success on flow validationdrivers/net/intel/iavf/iavf_generic_flow.c+3 -20 replies
4/10net/iavf: fix memory leaks around IRQ resourcesdrivers/net/intel/iavf/iavf_ethdev.c+16 -31 reply
5/10net/iavf: fix generic flow error-path leaksdrivers/net/intel/iavf/iavf_generic_flow.c+8 -20 replies
6/10net/iavf: centralize memory management for flowsdrivers/net/intel/iavf/iavf.h drivers/net/intel/iavf/iavf_fdir.c drivers/net/intel/iavf/iavf_fsub.c +4 more+97 -1370 replies
7/10net/iavf: skip RSS teardown during PF-initiated resetdrivers/net/intel/iavf/iavf_ethdev.c+4 -40 replies
8/10net/iavf: remove redundant reset checks from RSS enginedrivers/net/intel/iavf/iavf_hash.c+0 -100 replies
9/10net/iavf: fix null engine for egress security flowsdrivers/net/intel/iavf/iavf_generic_flow.c drivers/net/intel/iavf/iavf_generic_flow.h drivers/net/intel/iavf/iavf_ipsec_crypto.c+123 -430 replies
10/10net/iavf: fix IPsec flow metadata leaksdrivers/net/intel/iavf/iavf_ipsec_crypto.c+20 -80 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchBruce RichardsonRadu Nicolau
1/10A-b
2/10A-b
3/10A-b
4/10A-b
5/10A-b
6/10A-b
7/10A-b
8/10A-b
9/10A-b
10/10A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 00/10] IAVF Fixes

An assortment of IAVF flow-related memory leak fixes and cleanups.

v4 -> v5:
- Dropped the unnecessary EFD disable from patch 4

v3 -> v4:
- Fixed watchdog crash in commit 2

v2 -> v3:
- Rebase on top of latest next-net-intel including Anurag's fix [1]
- Dropped remnants of Anurag's patch [1] as it's now in the tree
- Fixed PF reset path still tearing down RSS when it shouldn't
- Fixed hash engine checking for VF reset when that's no longer necessary

v1 -> v2:
- Integrated Anurag's earlier fix [1] into the patchset
- Reworked generic flow to have centralized memory management
- Reordered some patches
- Integrated the IRQ leaks patchset [2] [3]
- Reworked IPsec fix

[1] https://patches.dpdk.org/project/dpdk/patch/[email protected]/
[2] https://patches.dpdk.org/project/dpdk/patch/809e0c5b2ab57f1b14c68be8ac34e70cbbe82233.1792053236.git.anatoly.burakov@intel.com/
[3] https://patches.dpdk.org/project/dpdk/patch/5488d85c2ded08838becaee6de8328694ee00234.1792053236.git.anatoly.burakov@intel.com/

Anatoly Burakov (10):
net/iavf: keep device stopped if start fails net/iavf: do not store ethdev pointer net/iavf: fix false success on flow validation net/iavf: fix memory leaks around IRQ resources net/iavf: fix generic flow error-path leaks net/iavf: centralize memory management for flows net/iavf: skip RSS teardown during PF-initiated reset net/iavf: remove redundant reset checks from RSS engine net/iavf: fix null engine for egress security flows net/iavf: fix IPsec flow metadata leaks

 drivers/net/intel/iavf/iavf.h              |  14 +-
 drivers/net/intel/iavf/iavf_ethdev.c       |  45 ++++--
 drivers/net/intel/iavf/iavf_fdir.c         |  68 ++++----
 drivers/net/intel/iavf/iavf_fsub.c         |  23 +--
 drivers/net/intel/iavf/iavf_generic_flow.c |  95 ++++++------
 drivers/net/intel/iavf/iavf_generic_flow.h |   4 +-
 drivers/net/intel/iavf/iavf_hash.c         | 103 ++++---------
 drivers/net/intel/iavf/iavf_ipsec_crypto.c | 171 +++++++++++++++++----
 drivers/net/intel/iavf/iavf_ipsec_crypto.h |   4 +-
 drivers/net/intel/iavf/iavf_vchnl.c        |   7 +-
 10 files changed, 300 insertions(+), 234 deletions(-)
Signature · 1 line
2.52.0