libdaxctl: Fix multi-range memory block handling
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest4 patches 2 repliesIn review
- v14 patches 9 repliesSuperseded
Changes in v2 from the cover letter
- Patch 3: Reset errno before each readdir() (GregoryP)
- Link to v1: https://lore.kernel.org/nvdimm/[email protected]/
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | libdaxctl: handle mapping initialization failuresdaxctl/ | +58 | 0 replies | |
| 2/4 | libdaxctl: tie mapping cache lifetime to the devicedaxctl/ | +6 | 0 replies | |
| 3/4 | libdaxctl: match memory blocks against each dax device mappingdaxctl/ | +15 | 1 reply | |
| 4/4 | test/daxctl-create.sh: count memory blocks across dax mappingstest/ | +58 | 0 replies |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Gregory Price (Meta) |
|---|---|
| 1/4 | R-b T-b |
| 2/4 | R-b |
| 3/4 | R-b |
| 4/4 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [ndctl PATCH v2 0/4] libdaxctl: Fix multi-range memory block handling
Changes in v2:
- Patch 3: Reset errno before each readdir() (GregoryP)
- Link to v1: https://lore.kernel.org/nvdimm/[email protected]/
Review and testing of Gregory's dax kmem atomic whole-device hotplug series[1] exposed an existing libdaxctl bug when handling DAX devices with multiple physical address ranges.
libdaxctl identifies a device's memory blocks using a single contiguous address window, even when the device has separate ranges with gaps between them. This can exclude blocks belonging to the device and include blocks belonging to another device in the gaps. As a result, daxctl can report incorrect memory block counts and potentially online or offline another device's memory.
Patches 1-2 address mapping reliability issues discovered while fixing the memory block ownership checks.
Patch 3 corrects the memory block ownership checks.
Patch 4 adds regression coverage using a two-range DAX device.
[1] https://lore.kernel.org/linux-cxl/[email protected]/
Alison Schofield (4):
libdaxctl: handle mapping initialization failures
libdaxctl: tie mapping cache lifetime to the device
libdaxctl: match memory blocks against each dax device mapping test/daxctl-create.sh: count memory blocks across dax mappings
daxctl/lib/libdaxctl.c | 98 ++++++++++++++++++++++++++++++++++-------- test/daxctl-create.sh | 58 +++++++++++++++++++++++++ 2 files changed, 137 insertions(+), 19 deletions(-)
Signature · 1 line
2.37.3