Skip to content

tools/bootconfig: Preserve filters when resetting and applying tracing

Eduardo Mucelli Rezende Oliveira linux-trace-kernel lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2tools/bootconfig: Preserve filters when resetting histogram triggerstools/bootconfig/scripts/ftrace.sh+2 -20 replies
2/2tools/bootconfig: Quote command strings when applying ftrace settingstools/bootconfig/scripts/bconf2ftrace.sh+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] tools/bootconfig: Preserve filters when resetting and applying tracing

Hi Masami,

Here are two more fixes for the bootconfig tracing scripts. They address resetting existing histograms and applying saved filter strings. The patches can be applied independently.

The first patch fixes histogram removal when a filter contains brackets or repeated spaces. A failed removal can leave a variable provider installed after reset, including a case where the helper returns success. It uses separate sed expressions for [active] and [paused], following your portability feedback.

The second patch keeps quoted strings intact when applying a bootconfig. Currently, repeated spaces can be collapsed and literal wildcard characters can expand to filenames, changing the filter being installed.

Both were tested in temporary tracefs instances on my Ubuntu machine, running kernel 7.0.0-38-generic, with recording disabled. The individual patch emails include the reproduction details.

Feedback is welcome.

Thanks,
Eduardo

Eduardo Mucelli Rezende Oliveira (2):
tools/bootconfig: Preserve filters when resetting histogram triggers tools/bootconfig: Quote command strings when applying ftrace settings

 tools/bootconfig/scripts/bconf2ftrace.sh | 2 +-
 tools/bootconfig/scripts/ftrace.sh       | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

base-commit: e28458ef30ad66ce7cd2299ec5ee8a8a016d67ff

Signature · 1 line
2.53.0