tools/bootconfig: Preserve tracing settings during export
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest4 patches 3 repliesIn review
- v14 patches 1 replySuperseded
Changes in v2 from the cover letter
- Patch 1: use explicit escapes in *[,\;\#\}]* for the delimiter check. The semicolon also needs escaping for the shell to parse the pattern.
- Patch 1: detect both quote types, warn on stderr and skip the filter.
- Patches 2-4: no changes.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | tools/bootconfig: Quote event filters in ftrace2bconf.shtools/ | +13 | 0 replies | |
| 2/4 | tools/bootconfig: Export replayable event trigger countstools/ | +9 | 0 replies | |
| 3/4 | tools/bootconfig: Reset histogram variable tracking for each instancetools/ | +2 | 0 replies | |
| 4/4 | tools/bootconfig: Preserve paused histograms in ftrace2bconf.shtools/ | +2 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/4] tools/bootconfig: Preserve tracing settings during export
Hi Masami,
Thanks for the review. I've updated the event-filter patch to use the explicit delimiter pattern you suggested. It now warns and skips filters that contain delimiters and both quote types, since bootconfig cannot represent them. The other three patches are unchanged.
Changes in v2:
- Patch 1: use explicit escapes in *[,\;\#\}]* for the delimiter check. The semicolon also needs escaping for the shell to parse the pattern.
- Patch 1: detect both quote types, warn on stderr and skip the filter.
- Patches 2-4: no changes.
The series keeps event filters, generic trigger counts, histogram variable ordering and paused histogram state during export. It is still based on bootconfig/fixes, including the two fixes you picked up earlier.
I retested the filter change in a temporary tracefs instance on my Ubuntu machine, running kernel 7.0.0-38-generic, with recording disabled. I also checked the mixed-quote cases against real tracefs filters and added regression checks for both quote orders and all four delimiters. The fixture checks cover each fix and the full series.
Feedback is welcome.
Thanks,
Eduardo
Eduardo Mucelli Rezende Oliveira (4):
tools/bootconfig: Quote event filters in ftrace2bconf.sh tools/bootconfig: Export replayable event trigger counts tools/bootconfig: Reset histogram variable tracking for each instance tools/bootconfig: Preserve paused histograms in ftrace2bconf.sh
tools/bootconfig/scripts/ftrace2bconf.sh | 29 +++++++++++++++++++++--- 1 file changed, 26 insertions(+), 3 deletions(-)
base-commit: 1dc6d173c43e10a1d0ee36b43d0d2f371f4d262a
Signature · 1 line
2.53.0