Skip to content

tools/bootconfig: Fix tracing script filters and histogram dependencies

Eduardo Mucelli Rezende Oliveira linux-trace-kernel lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5tools/bootconfig: Read the documented ftrace.notraces keytools/bootconfig/scripts/bconf2ftrace.sh+1 -10 replies
2/5tools/bootconfig: Preserve quotes in exported event actionstools/bootconfig/scripts/ftrace2bconf.sh+16 -10 replies
3/5tools/bootconfig: Ignore filter strings when resolving histogram variablestools/bootconfig/scripts/ftrace2bconf.sh+2 -20 replies
4/5tools/bootconfig: Resolve histogram dependencies until no progress is madetools/bootconfig/scripts/ftrace2bconf.sh+3 -30 replies
5/5tools/bootconfig: Match literal keys in tracing script helperstools/bootconfig/scripts/xbc.sh+9 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] tools/bootconfig: Fix tracing script filters and histogram dependencies

Hi Masami,

Thanks for the reviews and for picking up the previous fixes. Here are five more script fixes, based on bootconfig/core as you suggested.

They address:
- The documented ftrace.notraces setting being ignored by bconf2ftrace.sh.
- Single quotes in event actions producing invalid exported bootconfig.
- Literal filter text being mistaken for histogram variable syntax.
- Valid histogram dependency chains exceeding the exporter's retry limit.
- Helper key lookups matching unrelated bootconfig keys.

The action-quoting patch follows up on the trigger-filter fix you picked up. It uses the same warning approach for unrepresentable values that you suggested for event filters. The histogram scan uses POSIX sed.

I tested the conversion and export fixes in temporary tracefs instances on my Ubuntu machine, running kernel 7.0.0-38-generic, with recording disabled. The tests cover each relevant step and the combined series. The helper fix has focused checks, and all 81 combined fixture checks also pass with POSIX sed.

Feedback is welcome.

Thanks,
Eduardo

Eduardo Mucelli Rezende Oliveira (5):
tools/bootconfig: Read the documented ftrace.notraces key tools/bootconfig: Preserve quotes in exported event actions tools/bootconfig: Ignore filter strings when resolving histogram
variables
tools/bootconfig: Resolve histogram dependencies until no progress is
made
tools/bootconfig: Match literal keys in tracing script helpers

 tools/bootconfig/scripts/bconf2ftrace.sh |  2 +-
 tools/bootconfig/scripts/ftrace2bconf.sh | 27 ++++++++++++++++++------
 tools/bootconfig/scripts/xbc.sh          | 13 ++++++++----
 3 files changed, 31 insertions(+), 11 deletions(-)

base-commit: a52ceed51e9bf8f1ca9c2c868b14bf6861986c65

Signature · 1 line
2.53.0