Skip to content

x86/vmware: Clean up the hypercall code

Zack Rusin dri-devel kvm linux-coco lkml virtualization 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 0 repliesNew
  2. v33 patches 1 replySuperseded

Changes in v4 from the cover letter

- Forward TDX guests from the backdoor backend to the TDX backend, restoring the pre-series ULONG_MAX return on other hypervisors such as KVM instead of attempting port I/O (reported by Sashiko).
- Correct patch 2's description of the duplicated assembly.
- Rebase onto v7.4-rc2.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3x86/vmware: Move high-bandwidth hypercalls out of linearch/x86/include/asm/vmware.h arch/x86/kernel/cpu/vmware.c drivers/gpu/drm/vmwgfx/vmwgfx_msg.c+70 -630 replies
2/3x86/vmware: Route low-bandwidth hypercalls through a static callarch/x86/include/asm/vmware.h arch/x86/kernel/cpu/vmware.c+286 -2560 replies
3/3x86/cpufeatures: Remove unused VMware hypercall feature bitsarch/x86/include/asm/cpufeatures.h arch/x86/kernel/cpu/vmware.c+2 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/3] x86/vmware: Clean up the hypercall code

Move VMware hypercall assembly out of vmware.h and select the low-bandwidth backend with a static call, following Linus's request:
https://lore.kernel.org/all/CAHk-=wivx7pi+h+hGmvNFAJm6StQLiQ-b8DdsE5J=LMOWae8Ng@mail.gmail.com/

Patch 1 moves the high-bandwidth helpers out of line and removes the redundant vmwgfx caller annotations. Patch 2 uses input and result structures for the four low-bandwidth backends, selects the backend during VMware platform setup, and removes the early dispatcher. Patch 3 retires the unused VMware feature bits.

The caller API is unchanged. The I/O-port backdoor remains the initial target for early DMI probing. Modules use the exported high-bandwidth helpers and static-call trampoline; the static-call key stays private.

This series replaces patch 1 of Alexey's v2:
https://lore.kernel.org/all/[email protected]/
Its panic logging patches and steal-time fix were reposted separately:
https://lore.kernel.org/r/[email protected]
https://lore.kernel.org/r/[email protected]

It is based on v7.4-rc2, which includes the i386 high-bandwidth fix this series builds on: e0e022004bbe ("x86/vmware: Fix i386 high-bandwidth hypercall arguments").

Please route this through tip. As the vmwgfx maintainer, I agree that its small annotation removal should go through tip with the assembly move. DRM maintainers and dri-devel are copied. I'll make sure there are no conflicts in that code while the trees merge.

And yes, this code is a bit like me, meaning it gets on everyone's nerves and likely looks awkward in shorts, so we're just trying to make the best out of what a politician would call a less-than-ideal situation.

Changes since v3:
- Forward TDX guests from the backdoor backend to the TDX backend, restoring the pre-series ULONG_MAX return on other hypervisors such as KVM instead of attempting port I/O (reported by Sashiko).
- Correct patch 2's description of the duplicated assembly.
- Rebase onto v7.4-rc2.

Changes since v2:
- Replace the ten-argument backend interface with input/result structures.
- Move the high-bandwidth assembly out of the header as well.
- Preserve all low-bandwidth outputs and the backend-specific %dx flags.
- Export the callable trampoline without exporting its key.
- Correct the ABI documentation and retire unused feature bits.
- Keep the backportable i386 fix in its separate posting.

v3:
https://lore.kernel.org/r/[email protected]

Alexey Makhalov (1):
x86/vmware: Route low-bandwidth hypercalls through a static call

Zack Rusin (2):
x86/vmware: Move high-bandwidth hypercalls out of line x86/cpufeatures: Remove unused VMware hypercall feature bits

 arch/x86/include/asm/cpufeatures.h  |   4 +-
 arch/x86/include/asm/vmware.h       | 371 +++++++++++-----------------
 arch/x86/kernel/cpu/vmware.c        | 307 ++++++++++++++++-------
 drivers/gpu/drm/vmwgfx/vmwgfx_msg.c |   3 -
 4 files changed, 359 insertions(+), 326 deletions(-)

base-commit: 7475ea8b58616b33c04afb976cf0fbaad9dd63fb