Skip to content

shared/bap: Don't disconnect a CIS still used by another ASE

Luiz Augusto von Dentz linux-bluetooth 3 versions – Applied

Status from this message: This series was applied to bluetooth/bluez.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 1 replyApplied
  2. v24 patches 1 replySuperseded
  3. v14 patches 1 replySuperseded

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/5shared/bap: Don't disconnect a CIS still configured for a linksrc/shared/bap.c+59 -251 reply
2/5shared/bap: Hold the IO of a link when using itsrc/shared/bap.c+7 -00 replies
3/5unit/test-bap: Add tests for a CIS shared by two ASEsunit/test-bap.c+227 -00 replies
4/5doc/functional-bap: Document switching the direction of a CISdoc/functional-bap.rst+44 -00 replies
5/5test: functional: Cover switching the direction of a CIStest/functional/test_bap.py+86 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH BlueZ v3 0/5] shared/bap: Don't disconnect a CIS still used by another ASE

From: Luiz Augusto von Dentz <[email protected]>

A remote initiator, e.g. a phone in a voice call, may enable the Source ASE of a CIS shared with a Sink ASE and then switch to the Sink ASE alone. The acceptor disconnected the CIS when the Source ASE detached from it, although the linked Sink ASE was still configured for it, and as the initiator does not request the CIS again, the Sink ASE was left enabled without a CIS and the voice stayed silent.

Keep the CIS while another ASE is still configured for it. Unit tests cover releasing an ASE of a CIS kept by its link, of a shared CIS and switching the direction, and a functional test counts the CIS the acceptor is asked to accept.

v2: Also tell the streams using the CIS of a linked stream when it is
lost, not only the ones that hold it themselves.

v3: Hold the IO of a link when an ASE enabled again over the CIS its link
kept uses it (new patch 2/5), so disabling the link doesn't free the CIS while the ASE streams. The functional test covers it, and counts the second CIS requested after teardown.
v2: Also tell the streams using the CIS of a linked stream when it is
lost, not only the ones that hold it themselves.

Luiz Augusto von Dentz (5):
shared/bap: Don't disconnect a CIS still configured for a link shared/bap: Hold the IO of a link when using it unit/test-bap: Add tests for a CIS shared by two ASEs doc/functional-bap: Document switching the direction of a CIS
test: functional: Cover switching the direction of a CIS

 doc/functional-bap.rst      |  44 +++++++
 src/shared/bap.c            |  91 +++++++++++----
 test/functional/test_bap.py |  86 ++++++++++++++
 unit/test-bap.c             | 227 ++++++++++++++++++++++++++++++++++++
 4 files changed, 423 insertions(+), 25 deletions(-)
Signature · 1 line
2.56.0