Skip to content

ACPI: Use named initializers for acpi_device_id arrays

Uwe Kleine-König (The Capable Hub) linux-acpi linux-arm-kernel linux-pci lkml nvdimm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4ACPI: Unify acpi_device_id list terminatorsdrivers/acpi/ac.c drivers/acpi/acpi_memhotplug.c drivers/acpi/acpi_pad.c +26 more+34 -340 replies
2/4ACPI: Drop unused .driver_data initializers in acpi_device_id arraysdrivers/acpi/ac.c drivers/acpi/acpi_memhotplug.c drivers/acpi/acpi_pad.c +18 more+59 -590 replies
3/4ACPI: Use named initializers for acpi_device_id arraysdrivers/acpi/acpi_apd.c drivers/acpi/acpi_platform.c drivers/acpi/acpi_pnp.c +12 more+351 -3510 replies
4/4ACPI: Unify *_device_id list terminatorsdrivers/acpi/ac.c drivers/acpi/acpi_video.c drivers/acpi/battery.c +17 more+23 -230 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by.

PatchPawel Zalewski
1/4
2/4
3/4Co-Authored-by
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH v1 0/4] ACPI: Use named initializers for acpi_device_id arrays

From: Uwe Kleine-König <[email protected]>

Hello,

this series is about preparing drivers/acpi for a change to struct acpi_device_id. The idea is to replace .driver_data by an anonymous union, see
https://lore.kernel.org/all/[email protected]/
for more details. (The linked example is about platform_device_id, I intend to apply it acpi_device_id and several others, too.)

Before this union can be added, all initializers must use named initializers (C99 calls them designated initializers), which IMHO is a nice cleanup that can stand for itself as it makes the code easier to read.

Pawel sent a similar series earlier, find it at
https://lore.kernel.org/all/[email protected]/.
Compared to that the patch splitting is done differently and the base here is newer.

I checked for the other *_device_id and for these there is nothing to do below drivers/acpi because the few instances already use named initializers.

The last patch in this series is just some cosmetic to align the coding style. If you consider it churn, just drop it.

It would be great to get this series in soon, as keeping it up to date for a later resend is an annoying effort. Thanks for your cooperation.

Best regards
Uwe

Uwe Kleine-König (The Capable Hub) (4):
ACPI: Unify acpi_device_id list terminators
ACPI: Drop unused .driver_data initializers in acpi_device_id arrays
ACPI: Use named initializers for acpi_device_id arrays
ACPI: Unify *_device_id list terminators

 drivers/acpi/ac.c                       |   6 +-
 drivers/acpi/acpi_apd.c                 |  46 +--
 drivers/acpi/acpi_memhotplug.c          |   4 +-
 drivers/acpi/acpi_pad.c                 |   4 +-
 drivers/acpi/acpi_platform.c            |  12 +-
 drivers/acpi/acpi_pnp.c                 | 514 ++++++++++++------------
 drivers/acpi/acpi_processor.c           |   6 +-
 drivers/acpi/acpi_tad.c                 |   4 +-
 drivers/acpi/acpi_video.c               |   4 +-
 drivers/acpi/apei/ghes-nvidia.c         |   2 +-
 drivers/acpi/arm64/amba.c               |   6 +-
 drivers/acpi/battery.c                  |   8 +-
 drivers/acpi/bus.c                      |   2 +-
 drivers/acpi/button.c                   |  14 +-
 drivers/acpi/container.c                |   8 +-
 drivers/acpi/dptf/dptf_pch_fivr.c       |  14 +-
 drivers/acpi/dptf/dptf_power.c          |  38 +-
 drivers/acpi/ec.c                       |   8 +-
 drivers/acpi/evged.c                    |   4 +-
 drivers/acpi/fan_core.c                 |   2 +-
 drivers/acpi/hed.c                      |   4 +-
 drivers/acpi/mipi-disco-img.c           |   2 +-
 drivers/acpi/nfit/core.c                |   4 +-
 drivers/acpi/osi.c                      |   2 +-
 drivers/acpi/pci_link.c                 |   4 +-
 drivers/acpi/pci_root.c                 |   4 +-
 drivers/acpi/pci_slot.c                 |   2 +-
 drivers/acpi/pfr_telemetry.c            |   4 +-
 drivers/acpi/pfr_update.c               |   4 +-
 drivers/acpi/pmic/intel_pmic_bxtwc.c    |   2 +-
 drivers/acpi/pmic/intel_pmic_chtdc_ti.c |   2 +-
 drivers/acpi/pmic/intel_pmic_chtwc.c    |   2 +-
 drivers/acpi/power.c                    |   2 +-
 drivers/acpi/processor_driver.c         |   6 +-
 drivers/acpi/processor_idle.c           |   2 +-
 drivers/acpi/sbs.c                      |   4 +-
 drivers/acpi/sbshc.c                    |   6 +-
 drivers/acpi/scan.c                     |  48 +--
 drivers/acpi/sleep.c                    |   2 +-
 drivers/acpi/thermal.c                  |   6 +-
 drivers/acpi/tiny-power-button.c        |   6 +-
 drivers/acpi/video_detect.c             |   2 +-
 drivers/acpi/x86/blacklist.c            |   2 +-
 drivers/acpi/x86/cmos_rtc.c             |   2 +-
 drivers/acpi/x86/lpss.c                 |  58 +--
 drivers/acpi/x86/s2idle.c               |  14 +-
 drivers/acpi/x86/utils.c                |  22 +-
 include/linux/acpi.h                    |   8 +-
 48 files changed, 466 insertions(+), 466 deletions(-)

base-commit: 6d582d78fad9d828e575ca0cdcff8ea47a77220b

Signature · 1 line
2.56.0.rc1