pmdomain: rockchip: RK3576 NPU domain supply and settle delay
Get series with b4
b4 am [email protected]Versions newest first
- v17 Latest3 patches 1 replyIn review
Changes in v17 from the cover letter
- Reorganized the series as Ulf asked, and split the fix for regulator domain initialization from the RK3576 NPU regulator handling.
- Following Finley Xiao's (Rockchip) review of v16, the RK3576 delay is now 15 us on NPUTOP and VOP only.
- Fixed the subdomains of a regulator domain being left in the wrong state at probe, reported by Vladimir Bely (1/3).
- The RK3576 NPU power domain uses DOMAIN_RK3576_R, the same macro Leonard Lausen's GPU patch added (2/3).
Patches in v17 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | pmdomain: rockchip: switch off the subdomains of a regulator domain at probedrivers/ | +54 | 1 reply | |
| 2/3 | pmdomain: rockchip: manage the RK3576 NPU domain supplydrivers/ | +1 | 0 replies | |
| 3/3 | pmdomain: rockchip: settle RK3576 NPUTOP and VOP after power-ondrivers/ | +31 | 0 replies |
Reviews trailers per patch
None of the 3 patches has a Reviewed-by or Acked-by.
| Patch | Vladimir Bely |
|---|---|
| 1/3 | T-b |
| 2/3 | |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v17 0/3] pmdomain: rockchip: RK3576 NPU domain supply and settle delay
This series fixes how the Rockchip power-domain driver initializes domains that need a regulator, adds proper regulator handling for the RK3576 NPU power domain, and adds a settle wait after power-on for some RK3576 power domains.
These are the pmdomain patches of the RK3576 NPU series, split out and rebased on Ulf's next, as Ulf asked after dropping v15 7, 9 and 10:
https://lore.kernel.org/all/CAPx+jO-KKvgRS0br-3QGh6Jt4efWJ+A6YoRZKFV_bcfB+8sm6w@mail.gmail.com/
The accel/rocket and DT patches follow as their own v17:
https://lore.kernel.org/all/[email protected]/
Based on: Ulf's next (844a13010b0b)
Changes in v17:
- Reorganized the series as Ulf asked, and split the fix for regulator domain initialization from the RK3576 NPU regulator handling.
- Following Finley Xiao's (Rockchip) review of v16, the RK3576 delay is now 15 us on NPUTOP and VOP only.
- Fixed the subdomains of a regulator domain being left in the wrong state at probe, reported by Vladimir Bely (1/3).
- The RK3576 NPU power domain uses DOMAIN_RK3576_R, the same macro Leonard Lausen's GPU patch added (2/3).
Testing:
Tested on a Radxa ROCK 4D, with these patches and the rest of v17 backported to Armbian's 7.3 kernel:
- With the NPU disabled in the DT, NPUTOP, NPU0 and NPU1 are switched off and idled at probe on every boot (16 boots). Without 1/3, all 14 boots left them on, and one of them hung.
- With the NPU enabled, 30 NPU power-ups after a warm reboot and 30 after a cold power-on, with identical output and no SError.
Logs: https://github.com/gahingwoo/linux-rk3576-npu/tree/main/board-logs
Tag changes:
- 3/3 changes the delay values of the v16 patch and is organized differently, so I've dropped Abel's and Heiko's Reviewed-by. Abel, Heiko, could you take another look?
Jiaxing Hu (3):
pmdomain: rockchip: switch off the subdomains of a regulator domain at
probe
pmdomain: rockchip: manage the RK3576 NPU domain supply
pmdomain: rockchip: settle RK3576 NPUTOP and VOP after power-on
drivers/pmdomain/rockchip/pm-domains.c | 115 ++++++++++++++++++++++++--------- 1 file changed, 85 insertions(+), 30 deletions(-)
base-commit: 844a13010b0b93f8561ef2c088f843647d5e552d
Signature · 1 line
2.43.0