Skip to content

clk: Improve consumer field in debugfs clk_summary

Geert Uytterhoeven dri-devel linux-arm-kernel linux-clk linux-omap linux-pm linux-renesas-soc linux-rockchip 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6clk: Remove unused clk.devdrivers/clk/clk.c drivers/clk/clk.h drivers/clk/clkdev.c+13 -261 reply
2/6clk: Add dev_clk_get_from_provider()drivers/clk/clk.c include/linux/clk.h+15 -61 reply
3/6clk: renesas: Convert to dev_clk_get_from_provider()drivers/clk/renesas/clk-mstp.c drivers/clk/renesas/r9a06g032-clocks.c drivers/clk/renesas/renesas-cpg-mssr.c +2 more+5 -51 reply
4/6drm/rockchip: dw_hdmi: Convert to dev_clk_get_from_provider()drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c+2 -11 reply
5/6ARM: OMAP2+: Convert to dev_clk_get_from_provider()arch/arm/mach-omap2/omap_device.c arch/arm/mach-omap2/omap_hwmod.c+3 -22 replies
6/6pmdomain: renesas: r8a78000: Convert to dev_clk_get_from_provider()drivers/pmdomain/renesas/r8a78000-mdlc.c+1 -10 replies

Reviews trailers per patch

4 of 6 patches have a Reviewed-by or Acked-by.

PatchBrian Masney
1/6
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/6] clk: Improve consumer field in debugfs clk_summary

Hi all,

When a driver uses of_clk_get_from_provider() to obtain clocks, the latter show up as "deviceless" in the consumer column of the clk_summary file in debugfs.

This patch series aims to improve that, by introducing a new variant dev_clk_get_from_provider() that also takes a consumer device. When callers provide it, the consumer's name will be shown in the clk_summary output.

Sample clk_summary change snippet on R-Car H1 Marzen:
- sata 1 1 0 62500000 0 0 50000 Y deviceless of_clk_get_from_provider
+ sata 1 1 0 62500000 0 0 50000 Y fc600000.sata dev_clk_get_from_provider

Overview:
- The first patch removes the unused "dev" member from struct clk and the "dev" parameter from clk_hw_create_clk(): it felt wrong to add yet another user of clk_hw_create_clk() passing a useless device pointer,
- The second patch introduces the new dev_clk_get_from_provider() function,
- Patches 3-6 convert users to the new helper:
- The Renesas clock patch was tested on R-Car H1 and H3, and should work fine on other Renesas SoCs,
- The Rockchip HDMI patch was only compile-tested, but is probably fine, too,
- The OMAP2+ patch definitely needs testing,
- The Renesas pmdomain patch depends on work in progress.

This series has been tested on R-Car H1, H3, and X5H.

Thanks for your comments!

Geert Uytterhoeven (6):
clk: Remove unused clk.dev
clk: Add dev_clk_get_from_provider()
clk: renesas: Convert to dev_clk_get_from_provider() [RFT] drm/rockchip: dw_hdmi: Convert to dev_clk_get_from_provider() [RFT] ARM: OMAP2+: Convert to dev_clk_get_from_provider() [RFC] pmdomain: renesas: r8a78000: Convert to
dev_clk_get_from_provider()

 arch/arm/mach-omap2/omap_device.c           |  2 +-
 arch/arm/mach-omap2/omap_hwmod.c            |  3 ++-
 drivers/clk/clk.c                           | 23 ++++++++++-----------
 drivers/clk/clk.h                           | 11 ++++------
 drivers/clk/clkdev.c                        | 14 ++++---------
 drivers/clk/renesas/clk-mstp.c              |  2 +-
 drivers/clk/renesas/r9a06g032-clocks.c      |  2 +-
 drivers/clk/renesas/renesas-cpg-mssr.c      |  2 +-
 drivers/clk/renesas/rzg2l-cpg.c             |  2 +-
 drivers/clk/renesas/rzv2h-cpg.c             |  2 +-
 drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c |  3 ++-
 drivers/pmdomain/renesas/r8a78000-mdlc.c    |  2 +-
 include/linux/clk.h                         | 10 +++++++--
 13 files changed, 38 insertions(+), 40 deletions(-)
Signature · 12 lines
2.43.0

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds