media: qcom: camss: Fix the X1E80100 lite CSID paths
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 8 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | media: qcom: camss: x1e80100: Use the lite clocks for the lite CSIDsdrivers/ | +4 | 1 reply | |
| 2/2 | media: qcom: camss: Map each CSID to the VFE it feedsdrivers/ | +41 | 5 replies |
Reviews trailers per patch
1 of 2 patches has a Reviewed-by or Acked-by.
| Patch | Loic Poulain |
|---|---|
| 1/2 | R-b |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] media: qcom: camss: Fix the X1E80100 lite CSID paths
The X1E80100 CAMSS resources, which Glymur reuses for its CSIDs and VFEs (also with Nihal's Glymur-specific resources [1]), have two problems on the lite paths:
- the lite CSIDs are given the full CSID clocks, so their CSI-2 receiver is never clocked and they never see a frame;
- CAMSS assumes CSID n feeds VFE n, but X1E80100 has three full CSIDs and two full VFEs, so CSID_LITE0 powers VFE_LITE1, CSID_LITE1 has no VFE to power and CSID2 powers VFE_LITE0.
Tested on an Asus Zenbook A16 (Glymur), Linux 7.3 with the X1E80100 CSID/VFE tables, streaming 8 frames from the HM1092 IR sensor on CSIPHY0 through each CSID/VFE pair with media-ctl and v4l2-ctl:
before after CSID0 -> VFE0 8 frames 8 frames CSID1 -> VFE1 8 frames 8 frames LITE0 -> LITE0 no frames 8 frames LITE1 -> LITE1 -EINVAL 8 frames CSID2 -> VFE0 no frames -EINVAL
The OV02C10 RGB sensor on CSIPHY4 through LITE1 -> LITE1 also goes from -EINVAL to 8 frames. libcamera still captures from both cameras. I ran the same tests again with Nihal's v3 [1] applied and the board's CSIPHY4 link on port@2, with the same results.
I don't have an X1E80100 machine; testing there would be welcome.
The series applies on its own and in either order with [1]. Patch 2 touches vfe_parent_dev_ops_get() like Allan's "media: qcom: camss: do not fail CSID power up without a matching VFE" [2]. They don't depend on each other; I'm happy to rebase on whichever lands first.
[1] https://lore.kernel.org/r/[email protected]
[2] https://lore.kernel.org/r/[email protected]
Jesse Casco (2):
media: qcom: camss: x1e80100: Use the lite clocks for the lite CSIDs
media: qcom: camss: Map each CSID to the VFE it feeds
drivers/media/platform/qcom/camss/camss.c | 54 +++++++++++++++++++---- 1 file changed, 45 insertions(+), 9 deletions(-)
base-commit: adcad7f4e6332cff3d6d7165f41584899f598534
Signature · 1 line
2.56.1