Skip to content

Input: drv260x: restore configuration across power loss

Maurizio Casciano linux-input lkml sashiko-reviews 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest2 patches 3 repliesIn review

Changes in v2 from the cover letter

- add a separate first patch restoring configuration after input close;
- stop overwriting the configured actuator mode during playback; and
- retain the suspend/resume sequencing fix while restoring all volatile configuration after the enable GPIO is asserted.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Input: drv260x: Restore configuration after device closedrivers/input/misc/drv260x.c+16 -22 replies
2/2Input: drv260x: Fix suspend and resume sequencingdrivers/input/misc/drv260x.c+33 -97 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] Input: drv260x: restore configuration across power loss

The DRV260x enable GPIO disables the I2C interface and resets volatile configuration when lowered. Closing the input device or suspending the system can therefore leave the controller unconfigured when it is used again.

Restore the actuator configuration when the input device is reopened and after system resume. Quiesce asynchronous force-feedback work during suspend, restore a usable state if regulator shutdown fails, and keep the firmware-selected actuator mode unchanged during playback.

Changes since v1:

- add a separate first patch restoring configuration after input close;
- stop overwriting the configured actuator mode during playback; and
- retain the suspend/resume sequencing fix while restoring all volatile configuration after the enable GPIO is asserted.

The previously posted optional-vbat change is withdrawn, as requested by Dmitry. The Yoga Book enable-GPIO mapping has also been removed from the generic Input driver and is provided by board software nodes in the separately posted platform/x86 v2 series.

Both patches pass strict checkpatch, W=1 and sparse v0.6.5-rc1. They were tested on a Lenovo Yoga Book YB1-X91L with both DRV2604 devices. An RTC-timed suspend-to-RAM and resume completed without rebooting, and both force-feedback devices played effects afterwards without drv260x, I2C or configuration-restore errors.

With Best Regards,
Maurizio Casciano

Maurizio Casciano (2):
Input: drv260x: Restore configuration after device close
Input: drv260x: Fix suspend and resume sequencing

 drivers/input/misc/drv260x.c | 58 +++++++++++++++++++++++++++++-------
 1 file changed, 48 insertions(+), 10 deletions(-)

base-commit: 9a29ee801f525bcad71fea021bfe2a030885c8df

Signature · 1 line
2.53.0