Skip to content

st.ko: some changes for enlarge_buffer

Bodo Stroesser linux-scsi 1 version In review

Get series with b4
b4 am '[email protected]'

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3st.ko: fix enlarge_bufferdrivers/scsi/st.c+1 -40 replies
2/3st.ko: remove unnecessary normalize_bufferdrivers/scsi/st.c+0 -30 replies
3/3st.ko: change enlarge_buffer resultdrivers/scsi/st.c+6 -92 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] st.ko: some changes for enlarge_buffer

Hi Kai,

here is a short series of 3 small patches for st.ko

The first one removes a bug in enlarge_buffer() that can make a read or write fail under special conditions.

The second one removes a small piece of code in enlarge_buffer(), that AFAICS is not necessary.

If enlarge_buffer() fails, the errno currently presented to userland always is EOVERFLOW, while I think it sometimes should be ENOMEM. The third patch is a try to enhance this.

All three patches are slightly tested under SLES11-SP2 kernel
3.0.80-0.7.1-xxxxx and after this adapted to 3.12.2 (just had to fix
some offset). They compile fine under 3.12.2

HTH

Thanks,
Bodo