Skip to content

net: add and use netdev_sw_irq_coalesce_default_on()

Heiner Kallweit netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesApplied 2/2

Patches in v1 All 2 applied

#Subject and filesSizeRepliesApplied
1/2net: add netdev_sw_irq_coalesce_default_on()include/linux/netdevice.h net/core/dev.c+17 -00 repliesApplied
2/2r8169: enable GRO software interrupt coalescing per defaultdrivers/net/ethernet/realtek/r8169_main.c+2 -00 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/2] net: add and use netdev_sw_irq_coalesce_default_on()

There are reports about r8169 not reaching full line speed on certain systems (e.g. SBC's) with a 2.5Gbps link.
There was a time when hardware interrupt coalescing was enabled per default, but this was changed due to ASPM-related issues on few systems.

Meanwhile we have sysfs attributes for controlling kind of "software interrupt coalescing" on the GRO level. However most distros and users don't know about it. So lets set a conservative default for both involved parameters. Users can still override the defaults via sysfs. Don't enable these settings on the fast ethernet chip versions, they are slow enough.

Even with these conservative setting interrupt load on my 1Gbps test system reduced significantly.

Follow Jakub's suggestion and put this functionality into net core so that other MAC drivers can reuse it.

Heiner Kallweit (2):
net: add netdev_sw_irq_coalesce_default_on()
r8169: enable GRO software interrupt coalescing per default

 drivers/net/ethernet/realtek/r8169_main.c |  2 ++
 include/linux/netdevice.h                 |  1 +
 net/core/dev.c                            | 16 ++++++++++++++++
 3 files changed, 19 insertions(+)
Signature · 1 line
2.38.1