Skip to content

x86: memcpy() / memset() (non-)ERMS flavors plus fallout

Jan Beulich xen-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest7 patches 2 repliesIn review
  2. v67 patches 13 repliesSuperseded
  3. v56 patches 11 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v46 patches1 replySuperseded
v37 patches12 repliesSuperseded

Patches in v7 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7x86: suppress ERMS for internal use when MISC_ENABLE.FAST_STRING is clearxen/arch/x86/cpu-policy.c xen/arch/x86/cpu/intel.c xen/arch/x86/include/asm/msr-index.h+24 -01 reply
2/7x86/alternatives: serialize after (self-)modifying codexen/arch/x86/alternative.c+8 -30 replies
3/7x86: re-work memset()xen/arch/x86/Makefile xen/arch/x86/alternative.c xen/arch/x86/memset.S +1 more+37 -130 replies
4/7x86: re-work memcpy()xen/arch/x86/Makefile xen/arch/x86/memcpy.S xen/arch/x86/string.c+21 -150 replies
5/7x86: control memset() and memcpy() inliningxen/arch/x86/arch.mk+3 -00 replies
6/7x86: introduce "hot" and "cold" page clearing functionsxen/arch/x86/clear_page.S xen/arch/x86/cpu/common.c xen/arch/x86/include/asm/asm-defns.h +2 more+86 -60 replies
7/7mm: allow page scrubbing routine(s) to be arch controlledxen/arch/arm/include/asm/page.h xen/arch/ppc/include/asm/page.h xen/arch/riscv/include/asm/page.h +5 more+113 -200 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchJason AndryukTeddy AstieAndrew CooperJulien GrallOleksii Kurochko
1/7R-b
2/7R-b
3/7R-b
4/7R-b R-b
5/7R-b Requested-by
6/7R-b
7/7R-b A-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v7 thread

Cover letter [PATCH v7 0/7] x86: memcpy() / memset() (non-)ERMS flavors plus fallout

While the performance varies quite a bit on older (pre-ERMS) and newer (ERMS) hardware, so far we've been going with just a single flavor of these two functions, and oddly enough with ones not consistent with one another. Using plain memcpy() / memset() on MMIO (video frame buffer) is generally okay, but the ERMS variant of memcpy() turned out to regress (boot) performance in a way easily visible to the human eye (meanwhile addressed by using ioremap_wc() there).

1: x86: suppress ERMS for internal use when MISC_ENABLE.FAST_STRING is clear 2: x86/alternatives: serialize after (self-)modifying code
3: x86: re-work memset()
4: x86: re-work memcpy()
5: x86: control memset() and memcpy() inlining
6: x86: introduce "hot" and "cold" page clearing functions
7: mm: allow page scrubbing routine(s) to be arch controlled

Jan