Skip to content

COPY_ARRAY, MOVE_ARRAY, DUP_ARRAY

René Scharfe git 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 4 repliesIn review
  2. v13 patches 7 repliesSuperseded

Changes in v2 from the cover letter

- add macro BARF_UNLESS_COPYABLE
- use __builtin_types_compatible_p if available

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4factor out BARF_UNLESS_COPYABLEgit-compat-util.h+5 -20 replies
2/4do full type check in BARF_UNLESS_COPYABLEgit-compat-util.h+6 -34 replies
3/4add DUP_ARRAYgit-compat-util.h+5 -00 replies
4/4use DUP_ARRAYattr.c builtin/am.c commit-graph.c +5 more+15 -160 replies

Reviews trailers per patch

None of the 4 patches has a Reviewed-by or Acked-by.

PatchJunio C Hamano
1/4
2/4Helped-by
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/4] COPY_ARRAY, MOVE_ARRAY, DUP_ARRAY

Changes since v1:
- add macro BARF_UNLESS_COPYABLE
- use __builtin_types_compatible_p if available

factor out BARF_UNLESS_COPYABLE
do full type check in BARF_UNLESS_COPYABLE
add DUP_ARRAY
use DUP_ARRAY

 attr.c                         |  3 +--
 builtin/am.c                   |  3 +--
 commit-graph.c                 |  3 +--
 commit-reach.c                 |  3 +--
 compat/mingw.c                 |  3 +--
 contrib/coccinelle/array.cocci |  7 +++++++
 git-compat-util.h              | 15 +++++++++++++--
 parse-options.c                |  3 +--
 pathspec.c                     |  6 ++----
 9 files changed, 28 insertions(+), 18 deletions(-)

Range-Diff gegen v1:

1:  052b9c103d < -:  ---------- do full type check in COPY_ARRAY and MOVE_ARRAY
-:  ---------- > 1:  f50df9208f factor out BARF_UNLESS_COPYABLE
-:  ---------- > 2:  6a98a8f2a2 do full type check in BARF_UNLESS_COPYABLE
2:  fb5544fc51 ! 3:  757baca245 add DUP_ARRAY

@@ Commit message
dst = ARRAY_DUP(src, n);

That would be more versatile, as it could be used in declarations as
- well. Making it type-safe would require the use of typeof from C23,
- though.
+ well. Making it type-safe would require the use of typeof_unqual from
+ C23, though.

So use the safe and compatible variant for now.

3: bfbf085ac3 = 4: 435fbd8e92 use DUP_ARRAY
--
2.39.0