checkpatch checks for trailing semicolons on conditionals
Status from this message: Applied, thanks.
Get series with b4
b4 am exportbomb.1187270320@pinkyVersions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | mips: irix_getcontext will always fail EFAULTarch/ | +1 | 1 reply | |
| 2/6 | powerpc: hash_preload fails to preload under CONFIG_PPC_MM_SLICESarch/ | +1 | 0 replies | |
| 3/6 | sh: remove extraneous ; on scif_sercon_putc wait looparch/ | +1 | 1 reply | |
| 4/6 | infiniband: mlx4_MAD_IFC copies out response unconditionallydrivers/ | +1 | 1 reply | |
| 5/6 | irda_nl_get_mode: always results in failurenet/ | +1 | 0 replies | |
| 6/6 | netfilter: xt_u32: fix length checks in u32_match_itnet/ | +1 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/6] checkpatch checks for trailing semicolons on conditionals
A couple of people suggested adding checks to checkpatch for trailing semicolons on conditionals, where the conditional block may not be actually conditional:
if (err); return err;
While regression testing the changes, I ran these checks across the whole of 2.6.23-rc3 and there appear to be 5 places where this is occurs (above and beyond the IPv6 one which triggered this effort) and a benign use which could be confused later which it seems safest to fix.
Following this email are 6 patches for these issues, relevant maintainers cc'd. All against 2.6.23-rc3
-apw