Skip to content

LSR flag preservation improvements

Ilpo Järvinen linux-serial lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest6 patches 1 replyIn review
  2. v36 patches 4 repliesSuperseded
  3. v26 patches 10 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 patch2 repliesSuperseded

Changes in v4 from the cover letter

- Tweak comments
- Fix URL link to earlier discussion & improve changelog

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6serial: 8250: Store to lsr_save_flags after lsr readdrivers/tty/serial/8250/8250_port.c+2 -01 reply
2/6serial: 8250: Create serial_lsr_in()drivers/tty/serial/8250/8250.h drivers/tty/serial/8250/8250_core.c drivers/tty/serial/8250/8250_port.c+25 -130 replies
3/6serial: 8250: Get preserved flags using serial_lsr_in()drivers/tty/serial/8250/8250_port.c+1 -10 replies
4/6serial: 8250: Adjust misleading LSR related commentdrivers/tty/serial/8250/8250_port.c+5 -30 replies
5/6serial: 8250_dw: Use serial_lsr_in() in dw8250_handle_irq()drivers/tty/serial/8250/8250_dw.c+2 -20 replies
6/6serial: 8250_dw: Store LSR into lsr_saved_flags in dw8250_tx_wait_empty()drivers/tty/serial/8250/8250_dw.c+3 -00 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchAndy Shevchenko
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/6] LSR flag preservation improvements

Improve LSR flag preservation. Not all devices preserve all LSR flags on read. Therefore, the non-permanent flags must be stored until consumed. 8250_port has handled this for some of the reads (but not all). Drivers not so much but it's unclear to me which of the devices actually clear flags on read so this series only does per driver fixes for DW.

I've just put Uwe as Co-dev-by and SoB according to Andy's suggestion in order to allow forward progress (Uwe indicated he's OK with any sensible combination of tags anyway). I agree with Uwe's position though that it would be nice to be able to record Acked-by in some (probably quite rare) cases even if the person is already SoB but I don't want to keep dragging this issue on and on over a single line patch :-).

v2:
- Added more patches

v3:
- Fix Uwe's email and convert it to Co-developed-by

v4:
- Tweak comments
- Fix URL link to earlier discussion & improve changelog

Ilpo Järvinen (6):
serial: 8250: Store to lsr_save_flags after lsr read
serial: 8250: Create serial_lsr_in()
serial: 8250: Get preserved flags using serial_lsr_in()
serial: 8250: Adjust misleading LSR related comment
serial: 8250_dw: Use serial_lsr_in() in dw8250_handle_irq()
serial: 8250_dw: Store LSR into lsr_saved_flags in

    dw8250_tx_wait_empty()
 drivers/tty/serial/8250/8250.h      | 20 ++++++++++++++++++++
 drivers/tty/serial/8250/8250_core.c |  3 +--
 drivers/tty/serial/8250/8250_dw.c   |  7 +++++--
 drivers/tty/serial/8250/8250_port.c | 23 ++++++++++-------------
 4 files changed, 36 insertions(+), 17 deletions(-)
Signature · 1 line
2.30.2