Skip to content

common: XSA-327 follow-up

Jan Beulich xen-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 1 replyIn review
  2. v12 patches 12 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2common: map_vcpu_info() cosmeticsxen/common/domain.c+4 -31 reply
2/2evtchn/fifo: don't enforce higher than necessary alignmentxen/common/event_fifo.c xen/include/public/event_channel.h xen/include/xlat.lst+23 -60 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchRoger Pau MonnéJulien Grall
1/2R-b A-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/2] common: XSA-327 follow-up

There are a few largely cosmetic things that were discussed in the context of the XSA, but which weren't really XSA material.

1: common: map_vcpu_info() cosmetics
2: evtchn/fifo: don't enforce higher than necessary alignment

I realize both changes are controversial. For the first one discussion was about the choice of error code. Neither EINVAL nor EFAULT represent the fact that it is a choice of implementation to not support mis-aligned structures. If ENXIO isn't liked, the best I can suggest are EOPNOTSUPP or (as previously suggested) EPERM. I think it ought to be possible to settle on an error code everyone can live with.

For the second one the question was whether the relaxation is useful to do. The original reason for wanting to make the change
remains: The original code here should not be used as an excuse to introduce similar over-alignment requirements elsewhere. I can live with the change getting rejected, but if so I'd like to request that some alternative be submitted to ensure that the immediate goal can still be reached.

Jan