Skip to content

hvc_console updates was Re: [BUG] hvc_console WARN() on current upstream

Milton Miller linuxppc-dev lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 5 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 5 patches the cover letter announces are in this archive.

Reviews trailers per patch

PatchChristian BorntraegerHendrik Brueckner
SeriesA-b A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] hvc_console updates was Re: [BUG] hvc_console WARN() on current upstream
Quoted 23 lines · Alan Cox
Quoted 2 lines · Benjamin Herrenschmidt

Seems that we are in interrupt, doing hvc_poll, which does tty_flip_buffer_push

Which means that someone has tty->low_latency set and is calling tty_flip_buffer_push in an IRQ. That has never been allowed or safe, and now it hurts ;)

/**
* tty_flip_buffer_push - terminal
* @tty: tty to push
*
* Queue a push of the terminal flip buffers to the line discipline.
This
* function must not be called from IRQ context if tty->low_latency
is set *
* In the event of the queue being busy for flipping the work will be
* held off and retried later.
*
* Locking: tty buffer lock. Driver locks in low latency mode.
*/

Quoted 2 lines

That comment has been there for some years in varying formats

I actually was preparing a patch for this problem after I had encountered
the a deadlock due to this. That is in the first patch. I then found
and made a few more cleanups, although I might have reordered the rest.

The history for setting low_latency is in the changelog of the first patch..

milton