hvc_console updates was Re: [BUG] hvc_console WARN() on current upstream
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 5 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 5 patches the cover letter announces are in this archive.
Reviews trailers per patch
| Patch | Christian Borntraeger | Hendrik Brueckner |
|---|---|---|
| Series | A-b A-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/5] hvc_console updates was Re: [BUG] hvc_console WARN() on current upstream
Quoted 23 lines · Alan Cox
Quoted 2 lines · Benjamin Herrenschmidt
Seems that we are in interrupt, doing
hvc_poll, which doestty_flip_buffer_pushWhich means that someone has
tty->low_latencyset and is callingtty_flip_buffer_pushin an IRQ. That has never been allowed or safe, and now it hurts ;)/**
*tty_flip_buffer_push- terminal
* @tty: tty to push
*
* Queue a push of the terminal flip buffers to the line discipline.
This
* function must not be called from IRQ context iftty->low_latency
is set *
* In the event of the queue being busy for flipping the work will be
* held off and retried later.
*
* Locking: tty buffer lock. Driver locks in low latency mode.
*/
Quoted 2 lines
That comment has been there for some years in varying formats
I actually was preparing a patch for this problem after I had encountered
the a deadlock due to this. That is in the first patch. I then found
and made a few more cleanups, although I might have reordered the rest.
The history for setting low_latency is in the changelog of the first patch..
milton