Skip to content

x86/apic: reset LDR in clear_local_APIC

Bandan Das lkml stable 2 versions – Applied

Status from this message: The following commit has been merged into the x86/urgent branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 0 repliesApplied
  2. v11 patch 6 repliesSuperseded

Changes in v2 from the cover letter

1/2: clear out the bogus initialization in bigsmp_init_apic_ldr 2/2: reword commit message as suggested by Thomas
v1 posted at https://lkml.org/lkml/2019/8/14/1

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/2x86/apic: Do not initialize LDR and DFR for bigsmparch/x86/kernel/apic/bigsmp_32.c+2 -220 replies
2/2x86/apic: include the LDR when clearing out apic registersarch/x86/kernel/apic/apic.c+4 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] x86/apic: reset LDR in clear_local_APIC

v2:
1/2: clear out the bogus initialization in bigsmp_init_apic_ldr 2/2: reword commit message as suggested by Thomas
v1 posted at https://lkml.org/lkml/2019/8/14/1

On a 32 bit RHEL6 guest with greater than 8 cpus, the kdump kernel hangs when calibrating apic. This happens because when apic initializes bigsmp, it also initializes LDR even though it probably wouldn't be used.

When booting into kdump, KVM apic incorrectly reads the stale LDR values from the guest while building the logical destination map even for inactive vcpus. While KVM apic can be fixed to ignore apics that haven't been enabled, a simple guest only change can be to just clear out the LDR.

Bandan Das (2):
x86/apic: Do not initialize LDR and DFR for bigsmp x86/apic: include the LDR when clearing out apic registers

 arch/x86/kernel/apic/apic.c      |  4 ++++
 arch/x86/kernel/apic/bigsmp_32.c | 24 ++----------------------
 2 files changed, 6 insertions(+), 22 deletions(-)
Signature · 1 line
2.20.1