monitor: suggest running "help" for command errors
Status from this message: Applied to my (badly named) qapi-next branch, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest4 patches 5 repliesApplied
- v44 patches 4 repliesSuperseded
- v32 patches 5 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 2 patches | 2 replies | Superseded | |
| v1 | 1 patch | 3 replies | Superseded |
Changes in v5 from the cover letter
Move "monitor: remove debug prints" to first in the series Minor fixes to comments and commit messages
Patches in v5 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | monitor: remove debug printsmonitor.c | +1 | 0 replies | |
| 2/4 | monitor: cleanup parsing of cmd name and cmd argumentsmonitor.c | +57 | 2 replies | |
| 3/4 | monitor: Point to "help" command on syntax errormonitor.c | +2 | 0 replies | |
| 4/4 | monitor: Fix failure path for "S" argumentmonitor.c | +1 | 0 replies |
Reviews trailers per patch
3 of 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Markus Armbruster | Luiz Capitulino |
|---|---|---|
| Series | R-b | A-b |
| 1/4 | R-b | |
| 2/4 | ||
| 3/4 | R-b | |
| 4/4 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v5 0/4] monitor: suggest running "help" for command errors
v5:
Move "monitor: remove debug prints" to first in the series Minor fixes to comments and commit messages
v4:
Better name for cmdline index pointer [1/4]
Change comment for monitor_parse_command as suggested in review [1/4] Fix potential compilation failure in debug print [1/4]
New - Fix failure path for argument type "S" [3/4]
New - Remove debug prints [4/4]
v3:
Track the current location directly in the command line [1/2] Fix potential qdict leak [1/2]
Document char **endp [1/2]
Rebase on top of changes and add reviewed-by [2/2]
v2:
Split up the command name and arguments parsing into separate functions. [1/2]
Skip checking for failures with commands that use the .cmd_new interface or the async interface since they are scheduled for removal [2/2]
Bandan Das (4):
monitor: remove debug prints
monitor: cleanup parsing of cmd name and cmd arguments
monitor: Point to "help" command on syntax error
monitor: Fix failure path for "S" argument
monitor.c | 122 +++++++++++++++++++++++++++++++------------------------------- 1 file changed, 61 insertions(+), 61 deletions(-)
Signature · 1 line
2.1.0