libertas update
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest48 patches 92 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/48 | libertas: Fix memory leak of RX skbsdrivers/ | +5 | 0 replies | |
| 2/48 | libertas: Remove cmd_oid from struct cmd_ctrl_nodedrivers/ drivers/ drivers/ | +4 | 0 replies | |
| 3/48 | libertas: Consolidate lbs_host_to_card_done() function.drivers/ drivers/ drivers/ +2 more | +27 | 0 replies | |
| 4/48 | libertas: select WIRELESS_EXTdrivers/ | +1 | 0 replies | |
| 5/48 | libertas: remove cmd_ctrl_node->cmdflagsdrivers/ drivers/ | +0 | 0 replies | |
| 6/48 | libertas: remove cmd_ctrl_node->statusdrivers/ drivers/ | +0 | 0 replies | |
| 7/48 | libertas: make more functions staticdrivers/ drivers/ | +8 | 3 replies | |
| 8/48 | libertas: handy function to call firmware commandsdrivers/ drivers/ drivers/ +1 more | +126 | 0 replies | |
| 9/48 | libertas: Don't claim to have checksummed incoming packets.drivers/ | +1 | 0 replies | |
| 10/48 | libertas: Move SET_BOOT2_VER command to if_usb where it belongsdrivers/ drivers/ | +5 | 0 replies | |
| 11/48 | libertas: Zero 'pdata_size' field in cmd_ctrl_node reliably.drivers/ | +2 | 0 replies | |
| 12/48 | libertas: Byteswap cmdptr->size in lbs_cmd()drivers/ | +1 | 0 replies | |
| 13/48 | libertas: don't cast a pointer to pointer ofdrivers/ | +11 | 0 replies | |
| 14/48 | libertas: fix data packet size errorsdrivers/ drivers/ | +4 | 3 replies | |
| 15/48 | libertas: Use lbs_cmd() for setting Boot2 versiondrivers/ | +16 | 0 replies | |
| 16/48 | libertas: Remove SET_BOOT2_VER support from the Big Switch Statement.drivers/ | +0 | 0 replies | |
| 17/48 | libertas: Fix endianness in boot2_version handling.drivers/ | +1 | 0 replies | |
| 18/48 | libertas: implement new scanning logicdrivers/ drivers/ | +361 | 0 replies | |
| 19/48 | libertas: when usb_submit_usb fails, include the error code in the printkdrivers/ | +2 | 0 replies | |
| 20/48 | libertas: Switch to using a callback function pointer for commandsdrivers/ drivers/ drivers/ | +34 | 0 replies | |
| 21/48 | libertas: endianness fixesdrivers/ drivers/ drivers/ +3 more | +23 | 0 replies | |
| 22/48 | libertas: Don't set IW_ENCODE_NOKEY when returning WEP keys.drivers/ | +1 | 0 replies | |
| 23/48 | libertas: Fix up error handling in lbs_setuserscan()drivers/ | +19 | 0 replies | |
| 24/48 | libertas: kill adapter->nr_cmd_pendingdrivers/ drivers/ drivers/ +2 more | +5 | 0 replies | |
| 25/48 | libertas: switch lbs_cmd() to take a callback function pointerdrivers/ drivers/ drivers/ +1 more | +7 | 0 replies | |
| 26/48 | libertas: clean up lbs_thread() to make it slightly more readabledrivers/ | +36 | 0 replies | |
| 27/48 | libertas: fix lbs_rtap attribute in sysfsdrivers/ drivers/ | +6 | 0 replies | |
| 28/48 | libertas: kill TxLockFlagdrivers/ drivers/ drivers/ | +25 | 0 replies | |
| 29/48 | libertas: kill struct lbs_adapterdrivers/ drivers/ drivers/ +16 more | +1046 | 0 replies | |
| 30/48 | libertas: use lbs_host_to_card_done() in lbs_tx_timeout()drivers/ | +17 | 0 replies | |
| 31/48 | libertas: cope with device which already has firmware loadeddrivers/ drivers/ | +23 | 0 replies | |
| 32/48 | libertas: stop debugfs code looking at cmdpendingqdrivers/ | +1 | 0 replies | |
| 33/48 | libertas: kill internal tx queue for PS modedrivers/ drivers/ drivers/ +1 more | +3 | 0 replies | |
| 34/48 | libertas: kill SendSinglePacket() function.drivers/ | +24 | 0 replies | |
| 35/48 | libertas: move lbs_hard_start_xmit() into tx.cdrivers/ drivers/ drivers/ | +33 | 0 replies | |
| 36/48 | libertas: kill lbs_process_tx() by merging it into lbs_hard_start_xmit()drivers/ | +13 | 0 replies | |
| 37/48 | libertas: clean up lbs_hard_start_xmit()drivers/ | +63 | 0 replies | |
| 38/48 | libertas: kill lbs_pre_start_xmit(), lib_mesh_pre_start_xmit()drivers/ | +2 | 0 replies | |
| 39/48 | libertas: stop using ieee80211 for radiotap devicedrivers/ drivers/ | +15 | 0 replies | |
| 40/48 | libertas: set dev_addr on rtap devicedrivers/ | +1 | 0 replies | |
| 41/48 | libertas: TX packet is radiotap iff it comes from rtap_devdrivers/ | +1 | 0 replies | |
| 42/48 | libertas: free successfully transmitted skbs againdrivers/ | +3 | 0 replies | |
| 43/48 | libertas: refactor the 'should I sleep?' decision in lbs_thread()drivers/ | +18 | 0 replies | |
| 44/48 | libertas: Move actual transmission to main threaddrivers/ drivers/ drivers/ | +71 | 0 replies | |
| 45/48 | libertas: remove unreachable code from process_rxed_802_11_packet()drivers/ | +32 | 0 replies | |
| 46/48 | libertas: fix error cases in lbs_process_rxed_802_11_packet()drivers/ | +8 | 0 replies | |
| 47/48 | libertas: kill lbs_upload_tx_packet()drivers/ drivers/ drivers/ | +16 | 0 replies | |
| 48/48 | libertas: kill (IS,SET,UNSET)_MESH_FRAME.drivers/ | +0 | 0 replies |
Reviews trailers per patch
1 of 48 patches has a Reviewed-by or Acked-by.
| Patch | Dan Williams |
|---|---|
| 1/48 | |
| 2/48 | |
| 3/48 | |
| 4/48 | |
| 5/48 | |
| 6/48 | |
| 7/48 | |
| 8/48 | |
| 9/48 | |
| 10/48 | |
| 11/48 | |
| 12/48 | |
| 13/48 | |
| 14/48 | |
| 15/48 | |
| 16/48 | |
| 17/48 | |
| 18/48 | A-b |
| 19/48 | |
| 20/48 | |
| 21/48 | |
| 22/48 | |
| 23/48 | |
| 24/48 | |
| 25/48 | |
| 26/48 | |
| 27/48 | |
| 28/48 | |
| 29/48 | |
| 30/48 | |
| 31/48 | |
| 32/48 | |
| 33/48 | |
| 34/48 | |
| 35/48 | |
| 36/48 | |
| 37/48 | |
| 38/48 | |
| 39/48 | |
| 40/48 | |
| 41/48 | |
| 42/48 | |
| 43/48 | |
| 44/48 | |
| 45/48 | |
| 46/48 | |
| 47/48 | |
| 48/48 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH] [00/48] libertas update
This is the first set of patches to clean up the libertas driver, from the tree at git://git.infradead.org/libertas-2.6.git
It removes the 'struct lbs_adapter' data structure, merging it into 'struct lbs_private', and removes a bunch of pointless unused fields from it.
It collapses the pointless nest of functions in the transmit path, which used to go pre_start_xmit->hard_start_xmit->lbs_process_tx->SendSinglePacket and now can be handled entirely in libertas_hard_start_xmit() -- thus removing the need to store information about which netdevice the packet belongs to, so the whole IS_MESH_FRAME / {UN,}SET_MESH_FRAME thing can go away too.
It slightly cleans up the RX code path too, along similar lines. There's more to be done here.
It fixes radiotap mode so that you can query it without crashing, and can even enable it and see packets, which is a shiny new feature. As an added bonus, you can even disable it again without crashing, too.
It also fixes a bunch of other things which offended me along the way, and makes a start at addressing the locking issues with command and data transmission to the device, partly by moving the actual TX packet submission to the context of the main worker thread.
There's more to be done, but it seems to make sense to merge at this point before I embark on the next batch...
Dan Williams (1):
libertas: select WIRELESS_EXT
David Woodhouse (39):
libertas: Fix memory leak of RX skbs
libertas: Remove cmd_oid from struct cmd_ctrl_node
libertas: Consolidate lbs_host_to_card_done() function.
libertas: Don't claim to have checksummed incoming packets.
libertas: Move SET_BOOT2_VER command to if_usb where it belongs
libertas: Zero 'pdata_size' field in cmd_ctrl_node reliably.
libertas: Byteswap cmdptr->size in lbs_cmd()
libertas: Use lbs_cmd() for setting Boot2 version
libertas: Remove SET_BOOT2_VER support from the Big Switch Statement.
libertas: Fix endianness in boot2_version handling.
libertas: when usb_submit_usb fails, include the error code in the printk
libertas: Switch to using a callback function pointer for commands
libertas: Don't set IW_ENCODE_NOKEY when returning WEP keys.
libertas: Fix up error handling in lbs_setuserscan()
libertas: kill adapter->nr_cmd_pending
libertas: switch lbs_cmd() to take a callback function pointer
libertas: clean up lbs_thread() to make it slightly more readable
libertas: fix lbs_rtap attribute in sysfs
libertas: kill TxLockFlag
libertas: kill struct lbs_adapter
libertas: use lbs_host_to_card_done() in lbs_tx_timeout()
libertas: cope with device which already has firmware loaded
libertas: stop debugfs code looking at cmdpendingq
libertas: kill internal tx queue for PS mode
libertas: kill SendSinglePacket() function.
libertas: move lbs_hard_start_xmit() into tx.c
libertas: kill lbs_process_tx() by merging it into lbs_hard_start_xmit()
libertas: clean up lbs_hard_start_xmit()
libertas: kill lbs_pre_start_xmit(), lib_mesh_pre_start_xmit()
libertas: stop using ieee80211 for radiotap device
libertas: set dev_addr on rtap device
libertas: TX packet is radiotap iff it comes from rtap_dev
libertas: free successfully transmitted skbs again
libertas: refactor the 'should I sleep?' decision in lbs_thread()
libertas: Move actual transmission to main thread
libertas: remove unreachable code from process_rxed_802_11_packet()
libertas: fix error cases in lbs_process_rxed_802_11_packet()
libertas: kill lbs_upload_tx_packet()
libertas: kill (IS,SET,UNSET)_MESH_FRAME.
Holger Schurig (7):
libertas: remove cmd_ctrl_node->cmdflags
libertas: remove cmd_ctrl_node->status
libertas: make more functions static
libertas: handy function to call firmware commands
libertas: fix data packet size errors
libertas: implement new scanning logic
libertas: endianness fixes
Li Zefan (1):
libertas: don't cast a pointer to pointer of
---
23 files changed, 1809 insertions(+), 2189 deletions(-)
Signature · 1 line
dwmw2