Skip to content

3.16.85-rc1 review

Ben Hutchings lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest61 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/61slcan: Fix memory leak in error pathdrivers/net/can/slcan.c+1 -00 replies
2/61can: slcan: Fix use-after-free Read in slcan_opendrivers/net/can/slcan.c+1 -10 replies
3/61slcan: not call free_netdev before rtnl_unlock in slcan_opendrivers/net/can/slcan.c+3 -00 replies
4/61slip: Fix memory leak in slip_open error pathdrivers/net/slip/slip.c+1 -00 replies
5/61slip: Fix use-after-free Read in slip_opendrivers/net/slip/slip.c+1 -10 replies
6/61slip: not call free_netdev before rtnl_unlock in slip_opendrivers/net/slip/slip.c+3 -00 replies
7/61net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobjectnet/core/net-sysfs.c+13 -110 replies
8/61net-sysfs: fix netdev_queue_add_kobject() breakagenet/core/net-sysfs.c+1 -00 replies
9/61net-sysfs: Call dev_hold always in netdev_queue_add_kobjectnet/core/net-sysfs.c+5 -20 replies
10/61net-sysfs: Call dev_hold always in rx_queue_add_kobjectnet/core/net-sysfs.c+5 -20 replies
11/61selinux: cleanup error reporting in selinux_nlmsg_perm()security/selinux/hooks.c+3 -40 replies
12/61selinux: convert WARN_ONCE() to printk() in selinux_nlmsg_perm()security/selinux/hooks.c+4 -30 replies
13/61selinux: Print 'sclass' as string when unrecognized netlink message occurssecurity/selinux/hooks.c+3 -20 replies
14/61selinux: rate-limit netlink message warnings in selinux_nlmsg_perm()security/selinux/hooks.c+5 -40 replies
15/61selinux: properly handle multiple messages in selinux_netlink_send()security/selinux/hooks.c+44 -240 replies
16/61drivers: usb: core: Don't disable irqs in usb_sg_wait() during URB submit.drivers/usb/core/message.c+7 -80 replies
17/61drivers: usb: core: Minimize irq disabling in usb_sg_cancel()drivers/usb/core/message.c+17 -200 replies
18/61USB: core: Fix free-while-in-use bug in the USB S-Glibrarydrivers/usb/core/message.c+8 -10 replies
19/61scsi: mptfusion: Add bounds check in mptctl_hp_targetinfo()drivers/message/fusion/mptctl.c+2 -00 replies
20/61scsi: mptfusion: Fix double fetch bug in ioctldrivers/message/fusion/mptctl.c+50 -1630 replies
21/61mwifiex: Fix possible buffer overflows in mwifiex_cmd_append_vsie_tlv()drivers/net/wireless/mwifiex/scan.c+7 -00 replies
22/61mwifiex: Fix possible buffer overflows in mwifiex_ret_wmm_get_status()drivers/net/wireless/mwifiex/wmm.c+4 -00 replies
23/61sg: O_EXCL and other lock handlingdrivers/scsi/sg.c+230 -1940 replies
24/61sg: prevent integer overflow when converting from sectors to bytesdrivers/scsi/sg.c+13 -40 replies
25/61scsi: sg: Change next_cmd_len handling to mirror upstreamdrivers/scsi/sg.c+3 -70 replies
26/61scsi: sg: protect accesses to 'reserved' page arraydrivers/scsi/sg.c+26 -210 replies
27/61scsi: sg: reset 'res_in_use' after unlinking reserved arraydrivers/scsi/sg.c+2 -00 replies
28/61scsi: sg: protect against races between mmap() and SG_SET_RESERVED_SIZEdrivers/scsi/sg.c+9 -30 replies
29/61scsi: sg: recheck MMAP_IO request length with lock helddrivers/scsi/sg.c+5 -20 replies
30/61scsi: sg: remove 'save_scat_len'drivers/scsi/sg.c+0 -20 replies
31/61scsi: sg: use standard lists for sg_requestsdrivers/scsi/sg.c+61 -860 replies
32/61scsi: sg: off by one in sg_ioctl()drivers/scsi/sg.c+1 -10 replies
33/61scsi: sg: factor out sg_fill_request_table()drivers/scsi/sg.c+35 -260 replies
34/61scsi: sg: fixup infoleak when using SG_GET_REQUEST_TABLEdrivers/scsi/sg.c+2 -30 replies
35/61scsi: sg: Re-fix off by one in sg_fill_request_table()drivers/scsi/sg.c+1 -10 replies
36/61scsi: sg: disable SET_FORCE_LOW_DMAdrivers/scsi/sg.c include/scsi/sg.h+9 -220 replies
37/61scsi: sg: check for valid direction before starting the requestdrivers/scsi/sg.c+34 -120 replies
38/61scsi: sg: close race condition in sg_remove_sfp_usercontext()drivers/scsi/sg.c+10 -20 replies
39/61scsi: sg: fix SG_DXFER_FROM_DEV transfersdrivers/scsi/sg.c+4 -10 replies
40/61scsi: sg: fix static checker warning in sg_is_valid_dxferdrivers/scsi/sg.c+5 -20 replies
41/61scsi: sg: only check for dxfer_len greater than 256Mdrivers/scsi/sg.c+2 -300 replies
42/61scsi: sg: don't return bogus Sg_requestsdrivers/scsi/sg.c+3 -22 replies
43/61scsi: sg: fix minor memory leak in error pathdrivers/scsi/sg.c+1 -00 replies
44/61scsi: sg: add sg_remove_request in sg_common_writedrivers/scsi/sg.c+3 -10 replies
45/61scsi: sg: add sg_remove_request in sg_writedrivers/scsi/sg.c+3 -10 replies
46/61signal: Extend exec_id to 64bitsfs/exec.c include/linux/sched.h kernel/signal.c+4 -40 replies
47/61USB: gadget: fix illegal array access in binding with UDCdrivers/usb/gadget/configfs.c+3 -00 replies
48/61ext4: Make checks for metadata_csum feature saferfs/ext4/ext4.h+11 -80 replies
49/61ext4: protect journal inode's blocks using block_validityfs/ext4/block_validity.c fs/ext4/inode.c+54 -00 replies
50/61ext4: unsigned int compared against zerofs/ext4/block_validity.c+2 -10 replies
51/61ext4: fix block validity checks for journal inodes using indirect blocksfs/ext4/block_validity.c+6 -00 replies
52/61ext4: don't perform block validity checks on the journal inodefs/ext4/extents.c+9 -40 replies
53/61ext4: add cond_resched() to ext4_protect_reserved_inodefs/ext4/block_validity.c+1 -00 replies
54/61x86/cpu: Rename cpu_data.x86_mask to cpu_data.x86_steppingarch/x86/include/asm/acpi.h arch/x86/include/asm/processor.h arch/x86/kernel/amd_nb.c +30 more+69 -690 replies
55/61x86/cpu: Add a steppings field to struct x86_cpu_idarch/x86/include/asm/cpu_device_id.h arch/x86/kernel/cpu/match.c include/linux/mod_devicetable.h+39 -10 replies
56/61x86/cpu: Add 'table' argument to cpu_matches()arch/x86/kernel/cpu/common.c+13 -100 replies
57/61x86/speculation: Add Special Register Buffer Data Sampling (SRBDS) mitigationDocumentation/ABI/testing/sysfs-devices-system-cpu Documentation/kernel-parameters.txt arch/x86/include/asm/cpufeatures.h +5 more+173 -00 replies
58/61x86/speculation: Add SRBDS vulnerability and mitigation documentationDocumentation/hw-vuln/special-register-buffer-data-sampling.rst+148 -00 replies
59/61x86/speculation: Add Ivy Bridge to affected listDocumentation/hw-vuln/special-register-buffer-data-sampling.rst+4 -30 replies
60/61random: always use batched entropy for get_random_u{32,64}drivers/char/random.c+0 -30 replies
61/61fs/binfmt_elf.c: allocate initialized memory in fill_thread_core_info()fs/binfmt_elf.c+1 -10 replies

Reviews trailers per patch

34 of 61 patches have a Reviewed-by or Acked-by.

PatchStephen SmalleyEwan D. MilneBart Van AsscheJason L Tibbitts IIIHannes ReineckeKyungtae KimChristoph HellwigEric DumazetJohannes ThumshirnGreg Kroah-HartmanKees CookChris ClaytonDouglas GilbertTony LuckPawan GuptaJosh PoimboeufNeelima KrishnanJan KaraNaresh KambojuOliver Hartkopp
1/61
2/61A-b
3/61
4/61
5/61
6/61R-b
7/61
8/61
9/61
10/61
11/61
12/61
13/61A-b
14/61
15/61R-b
16/61
17/61
18/61Reported-and-tested-by
19/61R-b
20/61R-b
21/61
22/61
23/61R-b
24/61
25/61
26/61R-b R-b R-b T-b R-b T-b
27/61R-b R-b
28/61A-b
29/61A-b
30/61R-b R-b T-b
31/61R-b R-b T-b
32/61A-b
33/61R-b R-b
34/61R-b R-b R-b
35/61A-b
36/61R-b R-b T-b
37/61R-b T-b
38/61R-b R-b T-b
39/61R-b T-b T-b A-b
40/61
41/61T-b R-b
42/61R-b A-b
43/61R-b R-b
44/61A-b
45/61A-b
46/61
47/61Reported-and-tested-by
48/61A-b
49/61
50/61
51/61
52/61T-b
53/61R-b
54/61
55/61R-b R-b
56/61R-b
57/61R-b R-b R-b T-b
58/61R-b R-b
59/61
60/61R-b
61/61A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 20 reviewers.

Read the v1 thread

Cover letter [PATCH 3.16 00/61] 3.16.85-rc1 review

This is the start of the stable review cycle for the 3.16.85 release. There are 61 patches in this series, which will be posted as responses to this one. If anyone has any issues with these being applied, please let me know.

Responses should be made by Thu Jun 11 18:03:51 UTC 2020. Anything received after that time might be too late.

All the patches have also been committed to the linux-3.16.y-rc branch of
https://git.kernel.org/pub/scm/linux/kernel/git/bwh/linux-stable-rc.git . A shortlog and diffstat can be found below.

Ben.

-------------

Akinobu Mita (1):
sg: prevent integer overflow when converting from sectors to bytes
[46f69e6a6bbbf3858617c8729e31895846c15a79]

Alan Stern (1):
USB: core: Fix free-while-in-use bug in the USB S-Glibrary
[056ad39ee9253873522f6469c3364964a322912b]

Alexander Potapenko (1):
fs/binfmt_elf.c: allocate initialized memory in fill_thread_core_info()
[1d605416fb7175e1adf094251466caa52093b413]

Ben Hutchings (2):

      scsi: sg: Change next_cmd_len handling to mirror upstream
         [65c26a0f39695ba01d9693754f27ca76cc8a3ab5,
          bf33f87dd04c371ea33feb821b60d63d754e3124]
      scsi: sg: Re-fix off by one in sg_fill_request_table()
         [587c3c9f286cee5c9cac38d28c8ae1875f4ec85b]

Colin Ian King (1):
ext4: unsigned int compared against zero
[fbbbbd2f28aec991f3fbc248df211550fbdfd58c]

Dan Carpenter (3):
scsi: mptfusion: Add bounds check in mptctl_hp_targetinfo()
[a7043e9529f3c367cc4d82997e00be034cbe57ca]
scsi: mptfusion: Fix double fetch bug in ioctl
[28d76df18f0ad5bcf5fa48510b225f0ed262a99b]
scsi: sg: off by one in sg_ioctl()
[bd46fc406b30d1db1aff8dabaff8d18bb423fdcf]

David Mosberger (2):
drivers: usb: core: Don't disable irqs in usb_sg_wait() during URB submit.
[98b74b0ee57af1bcb6e8b2e76e707a71c5ef8ec9]
drivers: usb: core: Minimize irq disabling in usb_sg_cancel()
[5f2e5fb873e269fcb806165715d237f0de4ecf1d]

Douglas Gilbert (1):
sg: O_EXCL and other lock handling
[cc833acbee9db5ca8c6162b015b4c93863c6f821]

Eric Dumazet (1):
net-sysfs: fix netdev_queue_add_kobject() breakage
[48a322b6f9965b2f1e4ce81af972f0e287b07ed0]

Eric W. Biederman (1):
signal: Extend exec_id to 64bits
[d1e7fd6462ca9fc76650fbe6ca800e35b24267da]

Hannes Reinecke (8):
scsi: sg: close race condition in sg_remove_sfp_usercontext()
[97d27b0dd015e980ade63fda111fd1353276e28b]
scsi: sg: disable SET_FORCE_LOW_DMA
[745dfa0d8ec26b24f3304459ff6e9eacc5c8351b]
scsi: sg: factor out sg_fill_request_table()
[4759df905a474d245752c9dc94288e779b8734dd]
scsi: sg: fixup infoleak when using SG_GET_REQUEST_TABLE
[3e0097499839e0fe3af380410eababe5a47c4cf9]
scsi: sg: protect accesses to 'reserved' page array
[1bc0eb0446158cc76562176b80623aa119afee5b]
scsi: sg: remove 'save_scat_len'
[136e57bf43dc4babbfb8783abbf707d483cacbe3]
scsi: sg: reset 'res_in_use' after unlinking reserved array
[e791ce27c3f6a1d3c746fd6a8f8e36c9540ec6f9]
scsi: sg: use standard lists for sg_requests
[109bade9c625c89bb5ea753aaa1a0a97e6fbb548]

Jason A. Donenfeld (1):

      random: always use batched entropy for get_random_u{32,64}
         [69efea712f5b0489e67d07565aad5c94e09a3e52]

Jia Zhang (1):
x86/cpu: Rename cpu_data.x86_mask to cpu_data.x86_stepping
[b399151cb48db30ad1e0e93dd40d68c6d007b637]

Johannes Thumshirn (5):
scsi: sg: check for valid direction before starting the request
[28676d869bbb5257b5f14c0c95ad3af3a7019dd5]
scsi: sg: don't return bogus Sg_requests
[48ae8484e9fc324b4968d33c585e54bc98e44d61]
scsi: sg: fix SG_DXFER_FROM_DEV transfers
[68c59fcea1f2c6a54c62aa896cc623c1b5bc9b47]
scsi: sg: fix static checker warning in sg_is_valid_dxfer
[14074aba4bcda3764c9a702b276308b89901d5b6]
scsi: sg: only check for dxfer_len greater than 256M
[f930c7043663188429cd9b254e9d761edfc101ce]

Josh Poimboeuf (1):
x86/speculation: Add Ivy Bridge to affected list
[3798cc4d106e91382bfe016caa2edada27c2bb3f]

Jouni Hogander (7):
can: slcan: Fix use-after-free Read in slcan_open
[9ebd796e24008f33f06ebea5a5e6aceb68b51794]
net-sysfs: Call dev_hold always in netdev_queue_add_kobject
[e0b60903b434a7ee21ba8d8659f207ed84101e89]
net-sysfs: Call dev_hold always in rx_queue_add_kobject
[ddd9b5e3e765d8ed5a35786a6cb00111713fe161]
net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject
[b8eb718348b8fb30b5a7d0a8fce26fb3f4ac741b]
slcan: Fix memory leak in error path
[ed50e1600b4483c049ce76e6bd3b665a6a9300ed]
slip: Fix memory leak in slip_open error path
[3b5a39979dafea9d0cd69c7ae06088f7a84cdafa]
slip: Fix use-after-free Read in slip_open
[e58c1912418980f57ba2060017583067f5f71e52]

Kyungtae Kim (1):
USB: gadget: fix illegal array access in binding with UDC
[15753588bcd4bbffae1cca33c8ced5722477fe1f]

Li Bin (1):
scsi: sg: add sg_remove_request in sg_common_write
[849f8583e955dbe3a1806e03ecacd5e71cce0a08]

Marek Milkovic (1):
selinux: Print 'sclass' as string when unrecognized netlink message occurs
[cded3fffbeab777e6ad2ec05d4a3b62c5caca0f3]

Mark Gross (4):
x86/cpu: Add 'table' argument to cpu_matches()
[93920f61c2ad7edb01e63323832585796af75fc9]
x86/cpu: Add a steppings field to struct x86_cpu_id
[e9d7144597b10ff13ff2264c059f7d4a7fbc89ac]
x86/speculation: Add SRBDS vulnerability and mitigation documentation
[7222a1b5b87417f22265c92deea76a6aecd0fb0f]
x86/speculation: Add Special Register Buffer Data Sampling (SRBDS) mitigation
[7e5b3c267d256822407a22fdce6afdf9cd13f9fb]

Oliver Hartkopp (1):
slcan: not call free_netdev before rtnl_unlock in slcan_open
[2091a3d42b4f339eaeed11228e0cbe9d4f92f558]

Paul Moore (1):
selinux: properly handle multiple messages in selinux_netlink_send()
[fb73974172ffaaf57a7c42f35424d9aece1a5af6]

Qing Xu (2):
mwifiex: Fix possible buffer overflows in mwifiex_cmd_append_vsie_tlv()
[b70261a288ea4d2f4ac7cd04be08a9f0f2de4f4d]
mwifiex: Fix possible buffer overflows in mwifiex_ret_wmm_get_status()
[3a9b153c5591548612c3955c9600a98150c81875]

Richard Guy Briggs (2):
selinux: cleanup error reporting in selinux_nlmsg_perm()
[e173fb2646a832b424c80904c306b816760ce477]
selinux: convert WARN_ONCE() to printk() in selinux_nlmsg_perm()
[d950f84c1c6658faec2ecbf5b09f7e7191953394]

Shijie Luo (1):
ext4: add cond_resched() to ext4_protect_reserved_inode
[af133ade9a40794a37104ecbcc2827c0ea373a3c]

Tahsin Erdogan (1):
ext4: Make checks for metadata_csum feature safer
[dec214d00e0d78a08b947d7dccdfdb84407a9f4d]

Theodore Ts'o (3):
ext4: don't perform block validity checks on the journal inode
[0a944e8a6c66ca04c7afbaa17e22bf208a8b37f0]
ext4: fix block validity checks for journal inodes using indirect blocks
[170417c8c7bb2cbbdd949bf5c443c0c8f24a203b]
ext4: protect journal inode's blocks using block_validity
[345c0dbf3a30872d9b204db96b5857cd00808cae]

Todd Poynor (2):
scsi: sg: protect against races between mmap() and SG_SET_RESERVED_SIZE
[6a8dadcca81fceff9976e8828cceb072873b7bd5]
scsi: sg: recheck MMAP_IO request length with lock held
[8d26f491116feaa0b16de370b6a7ba40a40fa0b4]

Tony Battersby (1):
scsi: sg: fix minor memory leak in error path
[c170e5a8d222537e98aa8d4fddb667ff7a2ee114]

Vladis Dronov (1):
selinux: rate-limit netlink message warnings in selinux_nlmsg_perm()
[76319946f321e30872dd72af7de867cb26e7a373]

Wu Bo (1):
scsi: sg: add sg_remove_request in sg_write
[83c6f2390040f188cc25b270b4befeb5628c1aee]

Yangerkun (1):
slip: not call free_netdev before rtnl_unlock in slip_open
[f596c87005f7b1baeb7d62d9a9e25d68c3dfae10]

 Documentation/ABI/testing/sysfs-devices-system-cpu |   1 +
 .../special-register-buffer-data-sampling.rst      | 149 ++++
 Documentation/kernel-parameters.txt                |  20 +
 Makefile                                           |   4 +-
 arch/x86/include/asm/acpi.h                        |   2 +-
 arch/x86/include/asm/cpu_device_id.h               |  27 +
 arch/x86/include/asm/cpufeatures.h                 |   2 +
 arch/x86/include/asm/processor.h                   |   2 +-
 arch/x86/include/uapi/asm/msr-index.h              |   4 +
 arch/x86/kernel/amd_nb.c                           |   2 +-
 arch/x86/kernel/asm-offsets_32.c                   |   2 +-
 arch/x86/kernel/cpu/amd.c                          |  28 +-
 arch/x86/kernel/cpu/bugs.c                         | 106 +++
 arch/x86/kernel/cpu/centaur.c                      |   4 +-
 arch/x86/kernel/cpu/common.c                       |  62 +-
 arch/x86/kernel/cpu/cpu.h                          |   1 +
 arch/x86/kernel/cpu/cyrix.c                        |   2 +-
 arch/x86/kernel/cpu/intel.c                        |  18 +-
 arch/x86/kernel/cpu/match.c                        |   7 +-
 arch/x86/kernel/cpu/microcode/intel.c              |   4 +-
 arch/x86/kernel/cpu/mtrr/generic.c                 |   2 +-
 arch/x86/kernel/cpu/mtrr/main.c                    |   4 +-
 arch/x86/kernel/cpu/perf_event_intel.c             |   2 +-
 arch/x86/kernel/cpu/perf_event_intel_lbr.c         |   2 +-
 arch/x86/kernel/cpu/perf_event_p6.c                |   2 +-
 arch/x86/kernel/cpu/proc.c                         |   4 +-
 arch/x86/kernel/head_32.S                          |   4 +-
 arch/x86/kernel/mpparse.c                          |   2 +-
 drivers/base/cpu.c                                 |   8 +
 drivers/char/hw_random/via-rng.c                   |   2 +-
 drivers/char/random.c                              |   3 -
 drivers/cpufreq/acpi-cpufreq.c                     |   2 +-
 drivers/cpufreq/longhaul.c                         |   6 +-
 drivers/cpufreq/p4-clockmod.c                      |   2 +-
 drivers/cpufreq/powernow-k7.c                      |   2 +-
 drivers/cpufreq/speedstep-centrino.c               |   4 +-
 drivers/cpufreq/speedstep-lib.c                    |   6 +-
 drivers/crypto/padlock-aes.c                       |   2 +-
 drivers/edac/amd64_edac.c                          |   2 +-
 drivers/edac/mce_amd.c                             |   2 +-
 drivers/hwmon/coretemp.c                           |   6 +-
 drivers/hwmon/hwmon-vid.c                          |   2 +-
 drivers/hwmon/k10temp.c                            |   2 +-
 drivers/hwmon/k8temp.c                             |   2 +-
 drivers/message/fusion/mptctl.c                    | 215 ++----
 drivers/net/can/slcan.c                            |   4 +
 drivers/net/slip/slip.c                            |   4 +
 drivers/net/wireless/mwifiex/scan.c                |   7 +
 drivers/net/wireless/mwifiex/wmm.c                 |   4 +
 drivers/scsi/sg.c                                  | 758 +++++++++++----------
 drivers/usb/core/message.c                         |  53 +-
 drivers/usb/gadget/configfs.c                      |   3 +
 drivers/video/fbdev/geode/video_gx.c               |   2 +-
 fs/binfmt_elf.c                                    |   2 +-
 fs/exec.c                                          |   2 +-
 fs/ext4/block_validity.c                           |  57 ++
 fs/ext4/ext4.h                                     |  19 +-
 fs/ext4/extents.c                                  |  13 +-
 fs/ext4/inode.c                                    |   5 +
 include/linux/mod_devicetable.h                    |   6 +
 include/linux/sched.h                              |   4 +-
 include/scsi/sg.h                                  |   1 -
 kernel/signal.c                                    |   2 +-
 net/core/net-sysfs.c                               |  39 +-
 security/selinux/hooks.c                           |  70 +-
 65 files changed, 1103 insertions(+), 689 deletions(-)
Signature · 2 lines
Ben Hutchings
The two most common things in the universe are hydrogen and stupidity.