IPv4/IPv6 unregistration deadlock fixes
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest7 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | syscall: Implement a convinience function restart_syscallinclude/ | +6 | 0 replies | |
| 2/7 | net-sysfs: Use rtnl_trylock in sysfs methods.net/ | +5 | 0 replies | |
| 3/7 | net: FIX ipv6_forward sysctl restartnet/ | +1 | 0 replies | |
| 4/7 | net: Fix devinet_sysctl_forwardnet/ | +2 | 0 replies | |
| 5/7 | net: Fix bridgeing sysfs handling of rtnl_locknet/ net/ | +4 | 0 replies | |
| 6/7 | net: Fix ipoib rtnl_lock sysfs deadlock.drivers/ drivers/ | +8 | 0 replies | |
| 7/7 | net: FIX bonding sysfs rtnl_lock deadlockdrivers/ | +6 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/7] IPv4/IPv6 unregistration deadlock fixes
A while ago it was noticed that unregistering network devices could cause deadlocks if virtual files that take the rtnl_lock were accessed at the wrong time.
After looking at the different possibilities the only way to solve it cleanly without some kind of busy loop appears to be reducing the scope of the rtnl lock.
I have not tackled the hard fix yet but I have tested our current work around and it does not succeed in restarting the system call and instead leaks -ERESTARNOSYS to userspace, because we do not have a signal pending.
Further the current work around misses several interesting places in the network stack where the deadlock can occur.
I have addressed the problems by making a common helper function and patching all of the places I could find that had this problem.
Eric