Skip to content

sysfs: Reduce the size of sysfs_dirent

Eric W. Biederman lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4sysfs: Add s_hash to sysfs_dirent and order directory entries by hashfs/sysfs/dir.c fs/sysfs/sysfs.h+120 -1080 replies
2/4sysfs: Reduce s_flags to an unsinged short so it packs well with s_modefs/sysfs/sysfs.h+3 -30 replies
3/4sysfs: Store the sysfs inode in an unsigned int.fs/sysfs/dir.c fs/sysfs/sysfs.h+3 -30 replies
4/4sysfs: Kill nlink counting.fs/sysfs/dir.c fs/sysfs/inode.c fs/sysfs/sysfs.h+0 -100 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] sysfs: Reduce the size of sysfs_dirent

After throwing rb_trees at the problem sysfs_dirent increased in size by
6 pointers, or 48 bytes. Since the point of having struct
sysfs_dirent is to keep the size down increasing in size that much seems unfortunate.

The following patches attack this problem and if I have counted right reduce the size of sysfs_dirent by 4 pointers on 64bit. Not quite where we were but reducing sysfs_dirent by 32bytes to 104 bytes is an improvement.

Eric