Skip to content

Fix mmap bugs with sysfs_remove_bin_file

Eric W. Biederman lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2sysfs: Fail bin file mmap if vma close is implemented.fs/sysfs/bin.c+8 -182 replies
2/2sysfs: only access bin file vm_ops with the active lockfs/sysfs/bin.c+26 -162 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Fix mmap bugs with sysfs_remove_bin_file

While reviewing the sysfs mmap code in fs/sysfs/bin.c I found two rather nasty potential issues.

The first is if one of our wrapped mmap implementations implements vma->close() we do not call it at sysfs_remove_bin_file time leading to who knows what carnage.

The second is that we are potentially accessing the wrapped vm_ops
after sysfs_remove_bin_file has completed. Which could be a problem
if it is a modular user.

I don't know of any real world instances of problems. None of the bin attribute mmaps functions that I know of today implement a close method. However it seems prudent to fix these now before we have track down some mysterious weird failure with hotunplug.

Eric W. Biederman (2):
sysfs: Fail bin file mmap if vma close is implemented.
sysfs: only access bin file vm_ops with the active lock

---
 fs/sysfs/bin.c |   68 ++++++++++++++++++++++++++++----------------------------
 1 files changed, 34 insertions(+), 34 deletions(-)