Skip to content

Sysfs cleanups

Eric W. Biederman linux-fsdevel linux-scsi lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest20 patches 107 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20sysfs: Implement sysfs_rename_linkfs/sysfs/symlink.c include/linux/sysfs.h+25 -081 replies
2/20driver core: Use sysfs_rename_link in device_renamedrivers/base/core.c+6 -120 replies
3/20sysfs: Remove now unnecessary error reporting suppression.fs/sysfs/dir.c fs/sysfs/symlink.c fs/sysfs/sysfs.h+21 -763 replies
4/20sysfs: Handle the general case of removing of directories with subdirectoriesfs/sysfs/dir.c+25 -2711 replies
5/20sysfs: Rename sysfs_d_iput to sysfs_dentry_iputfs/sysfs/dir.c+2 -21 reply
6/20sysfs: Use dentry_ops instead of directly playing with the dcachefs/sysfs/dir.c+46 -273 replies
7/20sysfs: Simplify sysfs_chmod_file semanticsfs/sysfs/file.c+1 -91 reply
8/20sysfs: Optimize just changing the sysfs file mode.fs/sysfs/inode.c+14 -83 replies
9/20sysfs: Simplify iattr assignmentsfs/sysfs/inode.c+3 -61 reply
10/20sysfs: Fix locking and factor out sysfs_sd_setattrfs/sysfs/inode.c fs/sysfs/sysfs.h+31 -221 reply
11/20sysfs: Update s_iattr on link and unlink.fs/sysfs/dir.c+14 -01 reply
12/20sysfs: Nicely indent sysfs_symlink_inode_operationsfs/sysfs/symlink.c+3 -31 reply
13/20sysfs: Implement sysfs_getattr & sysfs_permissionfs/sysfs/dir.c fs/sysfs/inode.c fs/sysfs/symlink.c +1 more+49 -121 reply
14/20sysfs: In sysfs_chmod_file lazily propagate the mode change.fs/sysfs/file.c+8 -231 reply
15/20sysfs: Kill sysfs_addrm_start and sysfs_addrm_finishfs/sysfs/dir.c fs/sysfs/file.c fs/sysfs/inode.c +2 more+34 -2031 reply
16/20sysfs: Propagate renames to the vfs on demandfs/namei.c fs/sysfs/dir.c fs/sysfs/inode.c +2 more+32 -1601 reply
17/20sysfs: Merge sysfs_rename_dir and sysfs_move_dirfs/sysfs/dir.c+28 -381 reply
18/20sysfs: Pass super_block to sysfs_get_inodefs/sysfs/dir.c fs/sysfs/inode.c fs/sysfs/mount.c +1 more+6 -50 replies
19/20sysfs: Kill unused sysfs_sb variable.fs/sysfs/mount.c fs/sysfs/sysfs.h+0 -30 replies
20/20sysfs: Normalize error handling in sysfs_fill_inodefs/sysfs/mount.c+11 -52 replies

Reviews trailers per patch

14 of 20 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchTejun HeoKay Sievers
SeriesA-b A-b A-b A-b
1/20A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b A-b
2/20
3/20
4/20
5/20A-b
6/20A-b
7/20A-b
8/20
9/20A-b
10/20A-b
11/20A-b
12/20A-b
13/20A-b
14/20A-b
15/20A-b
16/20A-b
17/20A-b
18/20
19/20
20/20A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/20] Sysfs cleanups

The following patch series cleans up sysfs to the point where itq is generally a good citizen of the vfs layer. The big theme is lazy synchronization from the sysfs data structures to the vfs data structures using the same techniques as most other distributed filesystems.

This allows the complete removal of i_mutex from the sysfs code, the death of lookup_one_noperm, and probably a few other weird cases that slip my tongue.

Included in this is the latest version of my work that merges sysfs_move_dir and sysfs_rename_dir to simplify maitenance of.

I have been running these patches for several months so there should be no really nasty surprises in here.

 drivers/base/core.c   |   18 +-
 fs/namei.c            |   22 --
 fs/sysfs/dir.c        |  565 ++++++++++++++-----------------------------------
 fs/sysfs/file.c       |   47 +----
 fs/sysfs/inode.c      |  154 ++++++++------
 fs/sysfs/mount.c      |   20 +-
 fs/sysfs/symlink.c    |   71 +++----
 fs/sysfs/sysfs.h      |   25 +--
 include/linux/namei.h |    1 -
 include/linux/sysfs.h |    9 +
 10 files changed, 325 insertions(+), 607 deletions(-)

Eric