Fix the binary ipc and uts namespace sysctls.
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 6 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | sysctl: Simplify sysctl_uts_stringkernel/ | +26 | 0 replies | |
| 2/4 | sysctl: Implement sysctl_uts_stringkernel/ | +32 | 0 replies | |
| 3/4 | sysctl: Simplify ipc ns specific sysctlskernel/ | +49 | 1 reply | |
| 4/4 | sysctl: Fix sys_sysctl interface of ipc sysctlskernel/ | +50 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/4] Fix the binary ipc and uts namespace sysctls.
The binary interface to the namespace sysctls was never implemented resulting in some really weird things if you attempted to use sys_sysctl to read your hostname for example.
This patch series simples the code a little and implements the binary sysctl interface.
In testing this patch series I discovered that our 32bit compatibility for the binary sysctl interface is imperfect. In particular KERN_SHMMAX and KERN_SMMALL are size_t sized quantities and are returned as 8 bytes on to 32bit binaries using a x86_64 kernel. However this has existing for a long time so it is not a new regression with the namespace work.
Gads the whole sysctl thing needs work before it stops being easy to shoot yourself in the foot.
Looking forward a little bit we need a better way to handle sysctls and namespaces as our current technique will not work for the network namespace. I think something based on the current overlapping sysctl trees will work but the proc side needs to be redone before we can use it.
Eric