Skip to content

Fix the binary ipc and uts namespace sysctls.

Eric W. Biederman lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4sysctl: Simplify sysctl_uts_stringkernel/sysctl.c+26 -1020 replies
2/4sysctl: Implement sysctl_uts_stringkernel/sysctl.c+32 -50 replies
3/4sysctl: Simplify ipc ns specific sysctlskernel/sysctl.c+49 -571 reply
4/4sysctl: Fix sys_sysctl interface of ipc sysctlskernel/sysctl.c+50 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] Fix the binary ipc and uts namespace sysctls.

The binary interface to the namespace sysctls was never implemented resulting in some really weird things if you attempted to use sys_sysctl to read your hostname for example.

This patch series simples the code a little and implements the binary sysctl interface.

In testing this patch series I discovered that our 32bit compatibility for the binary sysctl interface is imperfect. In particular KERN_SHMMAX and KERN_SMMALL are size_t sized quantities and are returned as 8 bytes on to 32bit binaries using a x86_64 kernel. However this has existing for a long time so it is not a new regression with the namespace work.

Gads the whole sysctl thing needs work before it stops being easy to shoot yourself in the foot.

Looking forward a little bit we need a better way to handle sysctls and namespaces as our current technique will not work for the network namespace. I think something based on the current overlapping sysctl trees will work but the proc side needs to be redone before we can use it.

Eric