Skip to content

sysfs lazification final

Eric W. Biederman linux-fsdevel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15sysfs: Update sysfs_setxattr so it updates secdata under the sysfs_mutexfs/sysfs/inode.c+29 -120 replies
2/15sysfs: Rename sysfs_d_iput to sysfs_dentry_iputfs/sysfs/dir.c+2 -20 replies
3/15sysfs: Use dentry_ops instead of directly playing with the dcachefs/sysfs/dir.c+46 -270 replies
4/15sysfs: Simplify sysfs_chmod_file semanticsfs/sysfs/file.c+1 -90 replies
5/15sysfs: Simplify iattr time assignmentsfs/sysfs/inode.c+3 -60 replies
6/15sysfs: Fix locking and factor out sysfs_sd_setattrfs/sysfs/inode.c fs/sysfs/sysfs.h+33 -205 replies
7/15sysfs: Update s_iattr on link and unlink.fs/sysfs/dir.c+18 -00 replies
8/15sysfs: Nicely indent sysfs_symlink_inode_operationsfs/sysfs/symlink.c+4 -40 replies
9/15sysfs: Implement sysfs_getattr & sysfs_permissionfs/sysfs/dir.c fs/sysfs/inode.c fs/sysfs/symlink.c +1 more+54 -170 replies
10/15sysfs: In sysfs_chmod_file lazily propagate the mode change.fs/sysfs/file.c+8 -230 replies
11/15sysfs: Gut sysfs_addrm_start and sysfs_addrm_finishfs/sysfs/dir.c fs/sysfs/sysfs.h+4 -890 replies
12/15sysfs: Propagate renames to the vfs on demandfs/namei.c fs/sysfs/dir.c fs/sysfs/inode.c +2 more+32 -1620 replies
13/15sysfs: Factor out sysfs_rename from sysfs_rename_dir and sysfs_move_dirfs/sysfs/dir.c fs/sysfs/sysfs.h+32 -330 replies
14/15sysfs: sysfs_setattr remove unnecessary permission check.fs/sysfs/inode.c+0 -40 replies
15/15sysfs: Protect sysfs_refresh_inode with inode mutex.fs/sysfs/inode.c+4 -00 replies

Reviews trailers per patch

All 15 patches have a Reviewed-by or Acked-by.

PatchTejun HeoSerge Hallyn
1/15A-b A-b
2/15A-b A-b
3/15A-b A-b
4/15A-b A-b
5/15A-b A-b
6/15A-b A-b
7/15A-b A-b
8/15A-b A-b
9/15A-b A-b
10/15A-b A-b
11/15A-b A-b
12/15A-b
13/15A-b A-b
14/15A-b A-b
15/15A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/15] sysfs lazification final

The sysfs code updates the vfs caches immediately when the sysfs data structures change causing a lot of unnecessary complications. The following patchset untangles that beast. Allowing for simpler more straight forward code, the removal of a hack from the vfs to support sysfs, and human comprehensible locking on sysfs.

Most of these patches have already been reviewed and acked from the last time I had time to work on sysfs.

This acks have been folded in and the two small bugs found in the previous review have been fixed in the trailing patches (they are minor enough nits that even a bisect that happens to land in the middle should not see sysfs problems).

In net the patches look like:

 fs/namei.c            |   22 ---
 fs/sysfs/dir.c        |  388 ++++++++++++++++---------------------------------
 fs/sysfs/file.c       |   41 +----
 fs/sysfs/inode.c      |  178 ++++++++++++++---------
 fs/sysfs/symlink.c    |   11 +-
 fs/sysfs/sysfs.h      |    9 +-
 include/linux/namei.h |    1 -
 7 files changed, 256 insertions(+), 394 deletions(-)

Eric