Skip to content

Start coping gsis < 16 that are not isa irqs.

Eric W. Biederman linux-acpi linux-sh linuxppc-dev lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14x86 acpi/irq: Introduce apci_isa_irq_to_gsiarch/ia64/kernel/acpi.c arch/x86/kernel/acpi/boot.c include/linux/acpi.h+17 -00 replies
2/14x86 acpi/irq: Teach acpi_get_override_irq to take a gsi not an isa_irqarch/x86/kernel/apic/io_apic.c include/linux/acpi.h+16 -110 replies
3/14x86 acpi/irq: pci device dev->irq is an isa irq not a gsidrivers/acpi/pci_irq.c+5 -30 replies
4/14x86 acpi/irq: Fix acpi_sci_ioapic_setup so it has both bus_irq and gsiarch/x86/kernel/acpi/boot.c+7 -50 replies
5/14x86 acpi/irq: Generalize mp_config_acpi_legacy_irqsarch/x86/kernel/acpi/boot.c+18 -120 replies
6/14x86 ioapic: Only export mp_find_ioapic and mp_find_ioapic_pin in io_apic.harch/x86/include/asm/mpspec.h+0 -40 replies
7/14x86 ioapic: Fix the types of gsi valuesarch/x86/include/asm/io_apic.h arch/x86/kernel/apic/io_apic.c+7 -70 replies
8/14x86 ioapic: Teach mp_register_ioapic to compute a global gsi_endarch/x86/include/asm/io_apic.h arch/x86/kernel/apic/io_apic.c arch/x86/kernel/sfi.c+8 -30 replies
9/14x86 ioapic: In mpparse use mp_register_ioapicarch/x86/kernel/mpparse.c+1 -240 replies
10/14x86 ioapic: Move nr_ioapic_registers calculation to mp_register_ioapic.arch/x86/kernel/apic/io_apic.c+8 -140 replies
11/14x86 ioapic: Optimize pin_2_irqarch/x86/kernel/apic/io_apic.c+4 -90 replies
12/14x86 ioapic: Simplify probe_nr_irqs_gsi.arch/x86/include/asm/mpspec.h arch/x86/kernel/acpi/boot.c arch/x86/kernel/apic/io_apic.c+3 -434 replies
13/14x86 acpi/irq: Handle isa irqs that are not identity mapped to gsi's.arch/x86/kernel/acpi/boot.c arch/x86/kernel/apic/io_apic.c+59 -60 replies
14/14x86 irq: Kill io_apic_renumber_irqarch/x86/include/asm/io_apic.h arch/x86/kernel/acpi/boot.c arch/x86/kernel/apic/es7000_32.c +1 more+0 -310 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/14] Start coping gsis < 16 that are not isa irqs.

It appears there are a few systems in the wild that use acpi interrupt source overrides to report a gsi > 16 is an isa irq.

This breaks all kinds of assumptions I figure any BIOS doing that probably should be shot as that is very much not a conservative position.

That said acpi appears to allow this insanity and on the basis of being liberal in what we accept we should try to do something reasonable, and keep our notions of gsi, isa irq, and linux irq as straight as we can.

To that end this patchset slightly modifies the gsi to linux irq mapping. Making it a 1 to 1 identity mapping except for the first 16 gsis. If those gsis are isa irqs (the typical and default acpi configuration) they will be mapped into the first 16 irqs. If those first 16 gsis are not isa irqs they will be given a linux irq number just past the last gsi. Allowing us the chance to use them.

This patchset is my attempt to straighten out our understanding of which kind of irq name is used where and the cleanups used to get there.

Thanks to Yinghai Lu <[email protected]> for taking the first stab at this and finding that there is a real world problem here. This patchset is inspired by his work, but little of it remains the same.

This patchset lies in the weird world between the acpi and x86 and ia64. Since most of the changes are x86 related I think it makes most sense to go via the x86 tree.

Eric W. Biederman (14):
x86 acpi/irq: Introduce apci_isa_irq_to_gsi
x86 acpi/irq: Teach acpi_get_override_irq to take a gsi not an isa_irq x86 acpi/irq: pci device dev->irq is an isa irq not a gsi
x86 acpi/irq: Fix acpi_sci_ioapic_setup so it has both bus_irq and gsi x86 acpi/irq: Generalize mp_config_acpi_legacy_irqs
x86 ioapic: Only export mp_find_ioapic and mp_find_ioapic_pin in io_apic.h x86 ioapic: Fix the types of gsi values
x86 ioapic: Teach mp_register_ioapic to compute a global gsi_end x86 ioapic: In mpparse use mp_register_ioapic
x86 ioapic: Move nr_ioapic_registers calculation to mp_register_ioapic. x86 ioapic: Optimize pin_2_irq
x86 ioapic: Simplify probe_nr_irqs_gsi.
x86 acpi/irq: Handle isa irqs that are not identity mapped to gsi's. x86 irq: Kill io_apic_renumber_irq

 arch/ia64/kernel/acpi.c          |    8 ++
 arch/x86/include/asm/io_apic.h   |   12 ++--
 arch/x86/include/asm/mpspec.h    |   10 ---
 arch/x86/kernel/acpi/boot.c      |  133 ++++++++++++++++++++++++--------------
 arch/x86/kernel/apic/es7000_32.c |   19 ------
 arch/x86/kernel/apic/io_apic.c   |   93 +++++++++++---------------
 arch/x86/kernel/mpparse.c        |   25 +-------
 arch/x86/kernel/sfi.c            |    4 +-
 drivers/acpi/pci_irq.c           |    8 ++-
 include/linux/acpi.h             |    5 +-
 10 files changed, 149 insertions(+), 168 deletions(-)

Eric