sysfs cleanups v3.
Status from this message: This is a note to let you know that I've just added the patch titled
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
Reviews trailers per patch
18 of 26 patches have a Reviewed-by or Acked-by.
| Patch | Tejun Heo | Kay Sievers |
|---|---|---|
| 1/26 | ||
| 2/26 | ||
| 3/26 | ||
| 4/26 | ||
| 5/26 | ||
| 6/26 | ||
| 7/26 | A-b | |
| 8/26 | A-b | |
| 9/26 | A-b | |
| 10/26 | ||
| 11/26 | A-b | |
| 12/26 | A-b | |
| 13/26 | A-b | |
| 14/26 | A-b | |
| 15/26 | A-b | |
| 16/26 | A-b | |
| 17/26 | A-b | |
| 18/26 | A-b | |
| 19/26 | A-b | |
| 20/26 | A-b | |
| 21/26 | A-b | |
| 22/26 | A-b | |
| 23/26 | ||
| 24/26 | A-b | A-b |
| 25/26 | A-b | |
| 26/26 | A-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/26] sysfs cleanups v3.
Here is the third respin of my sysfs patches.
Tejun had a good point I was doing to much when I touched __sysfs_read_dir. So that work has been split into 3 patches.
This made a good excuse for me to review the if (!dir_sd) check and be certain it was not needed. I have not found any actual problems so the resulting code is the same as the last patchset.
Now the change to delete each dirent in sysfs_read_dir is it's own separate patch so Tejun can happily beat me up on just that one idea. I honestly can't see how holding sysfs_mutex over the entire directory deletion helps anything.
The net change is less buggy than the current sysfs and a fair bit simpler.
git-diff-tree --stat v2.6.30-rc5..HEAD
drivers/base/core.c | 21 +-- fs/namei.c | 22 -- fs/sysfs/dir.c | 596 ++++++++++++++++--------------------------------- fs/sysfs/file.c | 47 +--- fs/sysfs/inode.c | 154 ++++++++------ fs/sysfs/mount.c | 20 +- fs/sysfs/symlink.c | 93 +++++---- fs/sysfs/sysfs.h | 28 +-- include/linux/namei.h | 1 - include/linux/sysfs.h | 9 + 10 files changed, 383 insertions(+), 608 deletions(-)
Eric